Bug 71477 - _dbus_auth_return_buffer(): unused argument
Summary: _dbus_auth_return_buffer(): unused argument
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.5
Hardware: Other All
: lowest trivial
Assignee: Havoc Pennington
QA Contact:
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-11-11 09:55 UTC by Chengwei Yang
Modified: 2014-01-06 16:31 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
[PATCH] _dbus_auth_return_buffer(): remove unused argument (3.51 KB, patch)
2013-11-11 09:57 UTC, Chengwei Yang
Details | Splinter Review

Description Chengwei Yang 2013-11-11 09:55:03 UTC
There is an unused argument of _dbus_auth_return_buffer(), its definition is:

/**
 * Returns a buffer with new data read into it.
 *
 * @param auth the auth conversation
 * @param buffer the buffer being returned
 * @param bytes_read number of new bytes added
 */
void
_dbus_auth_return_buffer (DBusAuth               *auth,
                          DBusString             *buffer,
                          int                     bytes_read)
{
  _dbus_assert (buffer == &auth->incoming);
  _dbus_assert (auth->buffer_outstanding);

  auth->buffer_outstanding = FALSE;
}


The bytes_read in fact doesn't used at all, a bug like bug#70218
Comment 1 Chengwei Yang 2013-11-11 09:57:03 UTC
Created attachment 89004 [details] [review]
[PATCH] _dbus_auth_return_buffer(): remove unused argument
Comment 2 Simon McVittie 2013-11-27 14:25:26 UTC
Sure, why not. Not important, though.
Comment 3 Simon McVittie 2014-01-06 16:31:14 UTC
Fixed in git for 1.7.10


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.