Created attachment 87221 [details] [review] patch for resolving this problem. Unused variable bytes_read in _dbus_message_loader_get_buffer. The author forgot to remove a variable in 271fa7fc335f332bb2be3beeef735334546c4957
Comment on attachment 87221 [details] [review] patch for resolving this problem. Review of attachment 87221 [details] [review]: ----------------------------------------------------------------- My two humble suggestions: * Please check the "patch" box when uploading a patch, so it's easy to review in Splinter. * Please ensure every patch buildable and did a 'make check' before upload. ::: dbus/dbus-transport-socket.c @@ -761,5 @@ > { > _dbus_verbose ("Out of memory decoding incoming data\n"); > _dbus_message_loader_return_buffer (transport->loader, > - buffer, > - _dbus_string_get_length (buffer) - orig_len); After that, orig_len defined but not used any more, should be deleted.
Created attachment 87265 [details] [review] patch for resolving this problem.
> My two humble suggestions: > * Please check the "patch" box when uploading a patch, so it's easy to > review in Splinter. > * Please ensure every patch buildable and did a 'make check' before > upload. I'm sorry for my carelessness. patch fixed.
Comment on attachment 87265 [details] [review] patch for resolving this problem. Review of attachment 87265 [details] [review]: ----------------------------------------------------------------- ::: dbus/dbus-transport.c @@ +1072,1 @@ > orig_len); still fail, orig_len used here but you removed it as above.
Oh, I have built and tested it with verbose mode off.
Created attachment 87270 [details] [review] patch for resolving this problem.
(In reply to comment #6) > Created attachment 87270 [details] [review] > patch for resolving this problem. Looks good, testing in several build configurations now.
(In reply to comment #7) > (In reply to comment #6) > > Created attachment 87270 [details] [review] [review] > > patch for resolving this problem. > > Looks good, testing in several build configurations now. It's OK.
Fixed in git for 1.7.6
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.