Bug 22207 - [ABI break] Remove all _run_ methods
Summary: [ABI break] Remove all _run_ methods
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://cgit.freedesktop.org/~smcv/tel...
Whiteboard: ABI-break, r+
Keywords: patch
Depends on: 22205 45459
Blocks: tp-glib-1.0
  Show dependency treegraph
Reported: 2009-06-10 06:47 UTC by Simon McVittie
Modified: 2012-02-09 06:58 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Description Simon McVittie 2009-06-10 06:47:03 UTC
+++ This bug was initially created as a clone of Bug #22205 +++

11:52 < barisione> _run_ functions are evil

The reentrant methods in telepathy-glib client code turn out not to be such a good idea.

Mission Control hasn't had them for a while, and has a slightly outdated fork of glib-client-gen.py that supports a command-line option to not generate them (and also a command-line option to generate blocking versions, but that's WONTFIX from my point of view, and no longer used anyway).

If we add a similar command-line option to telepathy-glib's glib-client-gen.py, we can replace MC's fork with the real one.

Also, in the long term (early in the 0.9 series?) we should deprecate _run_ altogether. I've added a command-line option to deprecate these methods, which works per "class".

My plan is that when I add Client, ChannelDispatcher etc. bindings, they will lack the _run_ methods altogether; existing classes will keep them, deprecate them in 0.9.0, and delete them when we break ABI.
Comment 1 Simon McVittie 2012-02-01 06:15:56 UTC
Here's a branch. It's based on a non-trivial merge of master into next - I don't know whether you want to review that or just say "ship it"?
Comment 2 Simon McVittie 2012-02-01 09:14:35 UTC
(In reply to comment #1)
> Here's a branch. It's based on a non-trivial merge of master into next

(which has now been reviewed, merged)
Comment 3 Jonny Lamb 2012-02-02 12:40:59 UTC
(In reply to comment #1)
> Here's a branch.

Comment 4 Simon McVittie 2012-02-09 06:58:47 UTC
Fixed in next, thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.