Bug 22205 - Allow not generating, or deprecating, _run_ methods
Summary: Allow not generating, or deprecating, _run_ methods
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Keywords: patch
Depends on:
Blocks: 22207
  Show dependency treegraph
Reported: 2009-06-10 06:45 UTC by Simon McVittie
Modified: 2010-03-30 12:58 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Description Simon McVittie 2009-06-10 06:45:51 UTC
11:52 < barisione> _run_ functions are evil

The reentrant methods in telepathy-glib client code turn out not to be such a good idea.

Mission Control hasn't had them for a while, and has a slightly outdated fork of glib-client-gen.py that supports a command-line option to not generate them (and also a command-line option to generate blocking versions, but that's WONTFIX from my point of view, and no longer used anyway).

If we add a similar command-line option to telepathy-glib's glib-client-gen.py, we can replace MC's fork with the real one.

Also, in the long term (early in the 0.9 series?) we should deprecate _run_ altogether. I've added a command-line option to deprecate these methods, which works per "class".

My plan is that when I add Client, ChannelDispatcher etc. bindings, they will lack the _run_ methods altogether; existing classes will keep them, deprecate them in 0.9.0, and delete them when we break ABI.
Comment 1 Will Thompson 2009-06-10 07:52:35 UTC
Comment 2 Simon McVittie 2009-06-12 04:13:07 UTC
Fixed in git, will be in 0.7.32.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.