Created attachment 143848 [details]
output from bisected commit with INTEL_DEBUG=fs
The following tests regressed in CI:
piglit.spec.arb_gpu_shader_int64.execution.fs-ishl-then-ishr piglit.spec.arb_gpu_shader_int64.execution.fs-ishl-then-ishr-loop piglit.spec.arb_gpu_shader_int64.execution.fs-ishl-then-ushr
Output from bisected and previous commits run with INTEL_DEBUG=fs is attached.
Bisected to the following commit:
Author: Ian Romanick <email@example.com>
Date: Wed Feb 27 20:12:46 2019 -0800
nir/algebraic: Add missing 64-bit extract_[iu]8 patterns
No shader-db changes on any Intel platform.
v2: Use a loop to generate patterns. Suggested by Jason.
v3: Fix a copy-and-paste bug in the extract_[ui] of ishl loop that would
replace an extract_i8 with and extract_u8. This broke ~180 tests. This
bug was introduced in v2.
Reviewed-by: Matt Turner <firstname.lastname@example.org> [v1]
Reviewed-by: Dylan Baker <email@example.com> [v2]
Acked-by: Jason Ekstrand <firstname.lastname@example.org> [v2]
Created attachment 143849 [details]
output from previous (working) commit with INTEL_DEBUG=fs
Heh... when you said it failed, I didn't realize the failure was an assertion. :) ICL doesn't have 64-bit integers. We lower 64-bit shifts, but it seems that there is no lowering for 64-bit extract operations.
We either need to disable this optimization for platforms that are going to lower 64-bit integer operations, add a lowering for 64-bit extract operations, or both.
Jason's https://gitlab.freedesktop.org/mesa/mesa/merge_requests/1344 is going to fix this.
Fixed by the following commit in master:
Author: Jason Ekstrand <email@example.com>
Date: Mon Jul 15 10:31:49 2019 -0500
nir,intel: Add support for lowering 64-bit nir_opt_extract_*
We need this when doing full software 64-bit emulation.
Fixes: cbad201c2b3 "nir/algebraic: Add missing 64-bit extract_[iu]8..."
Reviewed-by: Kenneth Graunke <firstname.lastname@example.org>
Reviewed-by: Ian Romanick <email@example.com>