| Summary: | _dbus_auth_return_buffer(): unused argument | ||
|---|---|---|---|
| Product: | dbus | Reporter: | Chengwei Yang <chengwei.yang.cn> |
| Component: | core | Assignee: | Havoc Pennington <hp> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | trivial | ||
| Priority: | lowest | CC: | chengwei.yang.cn |
| Version: | 1.5 | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
| Attachments: | [PATCH] _dbus_auth_return_buffer(): remove unused argument | ||
Created attachment 89004 [details] [review] [PATCH] _dbus_auth_return_buffer(): remove unused argument Sure, why not. Not important, though. Fixed in git for 1.7.10 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
There is an unused argument of _dbus_auth_return_buffer(), its definition is: /** * Returns a buffer with new data read into it. * * @param auth the auth conversation * @param buffer the buffer being returned * @param bytes_read number of new bytes added */ void _dbus_auth_return_buffer (DBusAuth *auth, DBusString *buffer, int bytes_read) { _dbus_assert (buffer == &auth->incoming); _dbus_assert (auth->buffer_outstanding); auth->buffer_outstanding = FALSE; } The bytes_read in fact doesn't used at all, a bug like bug#70218