Bug 15044

Summary:

xorg/driver/xf86-video-neomagic - Compile warning fixes

Product:

xorg

Reporter:

Paulo César Pereira de Andrade <pcpa>

Component:

Driver/Neomagic

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

Keywords:

janitor, patch

Version:

git

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
0001-Compile-warning-fix.patch	none
0002-Don-t-include-fbpseudocolor.h-as-it-is-no-longer-av.patch	none

Description Paulo César Pereira de Andrade 2008-03-15 18:00:05 UTC

Created attachment 15163 [details] [review]
0001-Compile-warning-fix.patch

Don't redeclare variable err; cut&paste error that caused warning about
mixed code and declarations.
  Minor consistency change to neo_pcirename.h.

Comment 1 Paulo César Pereira de Andrade 2008-05-12 13:38:55 UTC

Created attachment 16488 [details] [review]
0002-Don-t-include-fbpseudocolor.h-as-it-is-no-longer-av.patch

Don't include fbpseudocolor.h, as it is no longer available.

Comment 2 Julien Cristau 2008-05-13 03:54:45 UTC

commit 9a2a733e8fc337da838cbd081b22a62f9f97de02
Author: Paulo Cesar Pereira de Andrade <pcpa@mandriva.com.br>
Date:   Mon May 12 17:09:50 2008 -0300

    Don't include fbpseudocolor.h, as it is no longer available.

commit 38ca3645e9bded8226aba05c0e5fd6f7fc080c1a
Author: Paulo Cesar Pereira de Andrade <pcpa@mandriva.com.br>
Date:   Sat Mar 15 21:57:46 2008 -0300

    Compile warning fix.
    
      Don't redeclare variable err; cut&paste error that caused warning about
    mixed code and declarations.
      Minor consistency change to neo_pcirename.h.

Comment 3 Paulo César Pereira de Andrade 2008-05-14 08:54:24 UTC

(In reply to comment #2)
> commit 9a2a733e8fc337da838cbd081b22a62f9f97de02
> Author: Paulo Cesar Pereira de Andrade <pcpa@mandriva.com.br>
> Date:   Mon May 12 17:09:50 2008 -0300
> 
>     Don't include fbpseudocolor.h, as it is no longer available.
> 
> commit 38ca3645e9bded8226aba05c0e5fd6f7fc080c1a
> Author: Paulo Cesar Pereira de Andrade <pcpa@mandriva.com.br>
> Date:   Sat Mar 15 21:57:46 2008 -0300
> 
>     Compile warning fix.
> 
>       Don't redeclare variable err; cut&paste error that caused warning about
>     mixed code and declarations.
>       Minor consistency change to neo_pcirename.h.


  Thanks.

  Can you also please look at:
o https://bugs.freedesktop.org/show_bug.cgi?id=14979
  There is a genuine bug using wrong argument, and it doesn't compile
  due to a function argument name not matching it's usage.
o https://bugs.freedesktop.org/show_bug.cgi?id=15047
  cfb is no longer available, so this patch updates the glint driver
  accordingly. May need review or test of someone with actual hardware,
  as it is only guaranteed to not fail due to unresolved symbols.
o https://bugs.freedesktop.org/show_bug.cgi?id=15475
  Also update for the cfb removal. And also only guaranteed to not fail
  due to unresolved symbols (other than MGAGetClientPointer). Only patch
  1 is really important, patch 2 is only compile warning fixes.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.