Created attachment 15073 [details] [review] 0001-Compile-warning-fixes.patch This seens to also fix a genuine bug detected when checking the warning about integer conversion to pointer.
Created attachment 15859 [details] [review] 0001-Compile-warning-fixes.patch Patch remade. Also included a change to the name of one argument of the new function S3ValidMode(), so that the driver will compile.
The patch doesn't apply cleanly anymore, because the typo that caused it to become uncompilable was fixed in commit caa3a43d9798bdc82a3660df88e694e2e65df373 But the calls as "find_bios_string(ps3v->PciTag, ..." to the function with prototype "static unsigned char *find_bios_string(S3VPtr ps3v, ..." was not applied, so this bug report is still valid. Actually, the obsoleted version of the patch should now be the proper fix, and apply cleanly :-)
Patch being remade to have only changes truly required to have a functional binary.
Created attachment 17808 [details] [review] 0001-Correct-calls-to-find_bios_string.patch
Fixed in commit 29e413c850e18f43dbd011689973399c5d7d340d.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.