Bug 15047 - xorg/driver/xf86-video-glint - Remove dependency on cfb8_32
Summary: xorg/driver/xf86-video-glint - Remove dependency on cfb8_32
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/glint (show other bugs)
Version: git
Hardware: Other All
: medium normal
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2008-03-15 19:21 UTC by Paulo César Pereira de Andrade
Modified: 2008-07-29 10:36 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
0001-Compile-warning-fixes.patch (4.16 KB, patch)
2008-03-15 19:21 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0001-Compile-warning-fixes.patch (4.16 KB, patch)
2008-03-20 19:39 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0001-Remove-dependency-on-cfb.patch (2.17 KB, patch)
2008-04-12 19:05 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0002-Compile-warning-fixes.patch (3.18 KB, patch)
2008-04-12 19:06 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review
0001-Remove-dependency-on-cfb8_32.patch (2.57 KB, patch)
2008-07-18 12:35 UTC, Paulo César Pereira de Andrade
no flags Details | Splinter Review

Description Paulo César Pereira de Andrade 2008-03-15 19:21:26 UTC
Created attachment 15167 [details] [review]
0001-Compile-warning-fixes.patch

Don't declare or add to the appropriate ifdef unused variables.
  Change some variables from signed to unsigned or proper casting to match
function prototypes.
  Minor consistency change in glintpcirename.h.
Comment 1 Paulo César Pereira de Andrade 2008-03-20 19:39:30 UTC
Created attachment 15355 [details] [review]
0001-Compile-warning-fixes.patch

  Patch rebuilt agains't current git master.
  Also removed a "white space error", so that
git-am should not report that warning.
Comment 2 Paulo César Pereira de Andrade 2008-04-12 19:04:47 UTC
  About the compile warning patch, the REGION_*
macros generate a lot of warnings, and it is easy
to make a mistake (that I probably did in one or
another "janitor" patch, as it doesn't use it's
first argument).
Comment 3 Paulo César Pereira de Andrade 2008-04-12 19:05:20 UTC
Created attachment 15862 [details] [review]
0001-Remove-dependency-on-cfb.patch
Comment 4 Paulo César Pereira de Andrade 2008-04-12 19:06:11 UTC
Created attachment 15863 [details] [review]
0002-Compile-warning-fixes.patch

Patch remade to match current git, and also to
be applied after patch1 (but should really not
matter).
Comment 5 Paulo César Pereira de Andrade 2008-07-18 12:34:21 UTC
Alternate patch rebuild, that checks for the existence
of cfb8_32.bpp instead of removing the support for old
release also.
Comment 6 Paulo César Pereira de Andrade 2008-07-18 12:35:21 UTC
Created attachment 17758 [details] [review]
0001-Remove-dependency-on-cfb8_32.patch
Comment 7 Paulo César Pereira de Andrade 2008-07-29 10:36:03 UTC
Fixed in commit 7b6206e6ba9f1351e5c9fe45da14c18ef2b69ac9.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.