Two trivial patches attached, courtesy of Coverity. (Are these the first reports it’s produced for non-pre-existing issues?) (If it’s of interest, Coverity produced four reports for the sd-activation changes: two were false positives where it detected infinite loops which weren’t actually infinite due to callbacks in the main context; and these two.)
Created attachment 129975 [details] [review] test: Fix copy-paste error in waiting for a message in the tests The parameters to the test_pending_call_store_reply() call should match those to the dbus_pending_call_set_notify() immediately after. Coverity ID: 141876 Signed-off-by: Philip Withnall <withnall@endlessm.com>
Created attachment 129976 [details] [review] test: Remove an unnecessary NULL check in sd-activation test_transient_services() was checking whether (config == NULL), then shortly afterwards dereferencing config->bus_name (which is in fact dereferenced on all branches of the function). Remove the check and add some assertions to ensure a Config struct is always passed into the test (which it currently is). Coverity ID: 141877 Signed-off-by: Philip Withnall <withnall@endlessm.com>
(Also, bug #99999, woohoo!)
Comment on attachment 129975 [details] [review] test: Fix copy-paste error in waiting for a message in the tests Review of attachment 129975 [details] [review]: ----------------------------------------------------------------- Looks good
Comment on attachment 129976 [details] [review] test: Remove an unnecessary NULL check in sd-activation Review of attachment 129976 [details] [review]: ----------------------------------------------------------------- Looks fine
Fixed in git for 1.11.12. Let's see what Coverity thinks!
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.