Created attachment 129825 [details] [review]
doc: Clarify /etc/dbus-1/system.d and /usr/share/dbus-1/system.d

The documentation generally only mentioned the directory in /etc, even
though we actually prefer security policies to be installed in
/usr/share to allow for stateless and volatile systems (i.e. booting up
with an empty /etc).

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Comment on attachment 129825 [details] [review]
doc: Clarify /etc/dbus-1/system.d and /usr/share/dbus-1/system.d

Review of attachment 129825 [details] [review]:
-----------------------------------------------------------------

::: doc/dbus-api-design.duck
@@ +839,5 @@
>  security policy, and consider splitting up methods or providing more restricted
>  versions which accept constrained parameters, so that they can be exposed with
> +less restrictive security policies if needed by less trusted clients. Security
> +policies should be installed to $file($var($$(datadir$))) rather than
> +$(file($var($$(sysconfdir$))); the latter is intended for system administators.

It might be worth saying "Since dbus-daemon 1.10, security policies should..." since this is a relatively recent addition (you can't rely on it in something like Debian stable or RHEL).

Created attachment 129829 [details] [review]
doc: Clarify /etc/dbus-1/system.d and /usr/share/dbus-1/system.d

The documentation generally only mentioned the directory in /etc, even
though we actually prefer security policies to be installed in
/usr/share to allow for stateless and volatile systems (i.e. booting up
with an empty /etc).

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Comment on attachment 129829 [details] [review]
doc: Clarify /etc/dbus-1/system.d and /usr/share/dbus-1/system.d

Review of attachment 129829 [details] [review]:
-----------------------------------------------------------------

Looks good

Fixed in git for 1.11.12, thanks