On windows dbus source compiled with cmake can be configured to use the windows debug port displayed by dbgview or other debuggers with -DDBUS_USE_OUTPUT_DEBUG_STRING. Running dbus-daemon or dbus-monitor from such a configured build e.g. set DBUS_VERBOSE=1 bin/dbus-daemon.exe --session or set DBUS_VERBOSE=1 bin/dbus-monitor.exe returns a list of unwanted timestamps on stderr. 1486711202.032110 1486711202.078986 1486711202.079318 1486711202.080303 1486711202.081313 1486711202.081594 1486711202.081873 1486711202.082134 1486711202.082394 1486711202.082642 Those messages should be removed.
Created attachment 129466 [details] [review] Do not show unrelated stderr output with DBUS_VERBOSE when using windows debug port as output channel.
Comment on attachment 129466 [details] [review] Do not show unrelated stderr output with DBUS_VERBOSE when using windows debug port as output channel. Review of attachment 129466 [details] [review]: ----------------------------------------------------------------- Seems reasonable to me.
You might want to reword the first line of the commit message though so it’s a bit shorter.
(In reply to Philip Withnall from comment #2) > Seems reasonable to me. And me. (In reply to Philip Withnall from comment #3) > You might want to reword the first line of the commit message though so it’s > a bit shorter. (The first line is the entire commit message, in fact.) Yes please. Perhaps something more like this: Only print timestamps on stderr if verbose messages will go there On Windows, dbus can be configured to send DBUS_VERBOSE messages to the Windows debug port instead of stderr. If we're in that configuration, we already avoided printing thread information to stderr before each verbose message; do the same for timestamps.
committed to git master with mentioned commit message change applied
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.