Bug 99723 - test: Simplify error checking path in test-service slightly
Summary: test: Simplify error checking path in test-service slightly
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: D-Bus Maintainers
QA Contact: D-Bus Maintainers
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-02-09 09:42 UTC by Philip Withnall
Modified: 2017-02-13 16:41 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
test: Simplify error checking path in test-service slightly (1.15 KB, patch)
2017-02-09 09:42 UTC, Philip Withnall 		Details | Splinter Review
View All

Description Philip Withnall 2017-02-09 09:42:14 UTC 
Trivial patch attached.
Comment 1 Philip Withnall 2017-02-09 09:42:17 UTC 
Created attachment 129426 [details] [review]
test: Simplify error checking path in test-service slightly

This should shut up Coverity from complaining about not checking the
return value of dbus_set_error_from_message(), which is equivalent to
the (type == DBUS_MESSAGE_TYPE_ERROR) check.

Coverity ID: 54697

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Simon McVittie 2017-02-13 16:41:48 UTC 
Fixed in git for 1.11.10, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.