Bug 99694 - test: Add missing error handling to some name-test tests
Summary: test: Add missing error handling to some name-test tests
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: D-Bus Maintainers
QA Contact: D-Bus Maintainers
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-02-06 13:17 UTC by Philip Withnall
Modified: 2017-02-13 15:58 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
test: Add missing error handling to some name-test tests (4.23 KB, patch)
2017-02-06 13:17 UTC, Philip Withnall
Details | Splinter Review

Description Philip Withnall 2017-02-06 13:17:48 UTC
Trivial patch attached.
Comment 1 Philip Withnall 2017-02-06 13:17:51 UTC
Created attachment 129363 [details] [review]
test: Add missing error handling to some name-test tests

Also take the opportunity to tweak the test-threads-init messages
slightly to make it more TAP-compliant. It is not entirely TAP compliant
because it doesn’t print a test plan before starting its tests.

Coverity IDs: 54701, 54714, 54726

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Simon McVittie 2017-02-07 10:54:00 UTC
Comment on attachment 129363 [details] [review]
test: Add missing error handling to some name-test tests

Review of attachment 129363 [details] [review]:
-----------------------------------------------------------------

Looks fine, thanks.

> It is not entirely TAP compliant because it doesn't print a test plan before starting its tests.

Actually, printing the test plan at the end is TAP-compliant, although planning in advance is weakly preferred:

> The plan is optional but if there is a plan before the test points it must be the first non-diagnostic line output by the test file. In certain instances a test file may not know how many test points it will ultimately be running. In this case the plan can be the last non-diagnostic line in the output.
> —http://testanything.org/tap-specification.html §(The plan)
Comment 3 Simon McVittie 2017-02-13 15:58:26 UTC
Fixed in git for 1.11.10, thanks


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.