Bug 99643 - signals: Add some missing assertions to inline unit tests
Summary: signals: Add some missing assertions to inline unit tests
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: D-Bus Maintainers
QA Contact: D-Bus Maintainers
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-02-02 10:29 UTC by Philip Withnall
Modified: 2017-02-13 15:58 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
signals: Add some missing assertions to inline unit tests (1.42 KB, patch)
2017-02-02 10:29 UTC, Philip Withnall 		Details | Splinter Review
View All

Description Philip Withnall 2017-02-02 10:29:28 UTC 
Super-mega-trivial patch attached.
Comment 1 Philip Withnall 2017-02-02 10:29:31 UTC 
Created attachment 129290 [details] [review]
signals: Add some missing assertions to inline unit tests

check_parse() can return NULL on OOM, which we might as well handle
gracefully in the tests with an assertion, rather than an explosion. At
least it will shut Coverity up.

Coverity ID: 54724
Comment 2 Simon McVittie 2017-02-02 11:57:09 UTC 
Clearly fine
Comment 3 Simon McVittie 2017-02-13 15:58:35 UTC 
Fixed in git for 1.11.10, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.