Bug 99612 - connection: Fix an LSM label memory leak on an error handling path
Summary: connection: Fix an LSM label memory leak on an error handling path
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: D-Bus Maintainers
QA Contact: D-Bus Maintainers
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-01-31 10:08 UTC by Philip Withnall
Modified: 2017-02-01 19:01 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
connection: Fix an LSM label memory leak on an error handling path (1.94 KB, patch)
2017-01-31 10:08 UTC, Philip Withnall 		Details | Splinter Review
View All

Description Philip Withnall 2017-01-31 10:08:15 UTC 
Trivial patch attached.
Comment 1 Philip Withnall 2017-01-31 10:08:18 UTC 
Created attachment 129252 [details] [review]
connection: Fix an LSM label memory leak on an error handling path

This is almost certainly not going to make a difference, as it’s on the
OOM handling path; but the fewer leaks the better.

Coverity ID: 141058
Comment 2 Ralf Habacker 2017-01-31 10:36:42 UTC 
Comment on attachment 129252 [details] [review]
connection: Fix an LSM label memory leak on an error handling path

Review of attachment 129252 [details] [review]:
-----------------------------------------------------------------

looks good
Comment 3 Simon McVittie 2017-01-31 13:06:40 UTC 
Comment on attachment 129252 [details] [review]
connection: Fix an LSM label memory leak on an error handling path

Review of attachment 129252 [details] [review]:
-----------------------------------------------------------------

Yes please!
Comment 4 Simon McVittie 2017-02-01 19:01:10 UTC 
Fixed in git for 1.11.10. This is so vanishingly unlikely to actually happen that I'm not going to apply it to 1.10.x.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.