link = _dbus_list_get_first_link (&connection->filter_list); while (link != NULL) { DBusMessageFilter *filter = link->data; DBusList *next = _dbus_list_get_next_link (&connection->filter_list, link); filter->function = NULL; _dbus_message_filter_unref (filter); /* calls app callback */ link->data = NULL; link = next; } /************************************* * * Here is duplicated * ****************************************/ _dbus_list_clear (&connection->filter_list); /* ---- Done with stuff that invokes application callbacks */ _dbus_object_tree_unref (connection->objects); _dbus_hash_table_unref (connection->pending_replies); connection->pending_replies = NULL; /************************************* * * Here is duplicated * ****************************************/ _dbus_list_clear (&connection->filter_list);
Created attachment 128996 [details] [review] dbus-connection: Remove a duplicate _dbus_list_clear() call This was doing no harm (clearing an already-cleared list is a no-op), but it was also pointless. Signed-off-by: Philip Withnall <withnall@endlessm.com>
Looks good, thanks
Fixed in git for 1.11.10
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.