Bug 98486 - piglit-util.c:583:18: error: storage size of 't' isn't known
Summary: piglit-util.c:583:18: error: storage size of 't' isn't known
Alias: None
Product: piglit
Classification: Unclassified
Component: tests (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Piglit Mailing List
QA Contact: Piglit Mailing List
Keywords: bisected, regression
Depends on:
Reported: 2016-10-28 21:07 UTC by Vinson Lee
Modified: 2016-11-14 07:16 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Description Vinson Lee 2016-10-28 21:07:27 UTC
piglit: 7360914582e6f79d0652bea660c1b652bb5335eb (master)

MinGW build error

tests/util/piglit-util.c: In function 'piglit_time_is_monotonic':
tests/util/piglit-util.c:583:18: error: storage size of 't' isn't known
  struct timespec t;

e0048f4940f780550433da9bfc0fe2500079ae4e is the first bad commit
commit e0048f4940f780550433da9bfc0fe2500079ae4e
Author: Robert Bragg <robert@sixbynine.org>
Date:   Thu Aug 25 16:12:19 2016 +0100

    util: Add piglit_delay_ns() api

    Provides a utility for blocking the cpu for a requested time (best
    effort) and returning the actual duration blocked.

    This should e.g. be useful for comparing durations measured via arb
    timer queries vs a monotonic system clock, where it's acceptable if we
    don't achieve an exact reference delay on the cpu (say due to OS
    signalling or scheduling conditions) so long as we get told accurately
    how long the final delay ended up being.

    Signed-off-by: Robert Bragg <robert@sixbynine.org>
    Acked-by: Kenneth Graunke <kenneth@whitecape.org>

:040000 040000 7ee942a8d969a8b45e43b77eb4499b29b77eae51 6526956bf0d8d73174eb37a80ebdf86b3c34de4c M	tests
bisect run success
Comment 1 Vinson Lee 2016-11-14 07:16:48 UTC
commit 52fa3545035ce7c7520dcfaab69bc165d281b21c
Author: Vinson Lee <vlee@freedesktop.org>
Date:   Thu Nov 3 14:25:16 2016 -0700

    util: Include time.h on all platforms.
    Fix MinGW build error.
    piglit-util.c: In function 'piglit_time_is_monotonic':
    piglit-util.c:583:18: error: storage size of 't' isn't known
      struct timespec t;
    Fixes: e0048f4940f7 ("util: Add piglit_delay_ns() api")
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98486
    Signed-off-by: Vinson Lee <vlee@freedesktop.org>
    Reviewed-by: Brian Paul <brianp@vmware.com>
    Tested-by: Brian Paul <brianp@vmware.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.