Bug 9845 - localAllocateOffscreenLinear broken with granularity > 1
Summary: localAllocateOffscreenLinear broken with granularity > 1
Status: RESOLVED DUPLICATE of bug 9931
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: x86 (IA32) All
: high major
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Keywords: patch
Depends on:
Reported: 2007-02-01 22:56 UTC by Jim Duchek
Modified: 2010-12-03 14:16 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Fixes bug (see bug) (588 bytes, patch)
2007-02-01 22:58 UTC, Jim Duchek
no flags Details | Splinter Review

Description Jim Duchek 2007-02-01 22:56:52 UTC
Granularity > 1 will cause linear->offset to be (generally) doubled.  This is quite bad if running OpenGL for whatever reason (AIGLX+Beryl) is mine, and attempting to do XVideo (on the Radeon at least -- haven't checked to see if it applies to other drivers' video implementation).  Either way it needs to be fixed.  I couldn't find a bug that seems to be related, although some other xvideo bugs (especially those regarding corruption) _might_ be.

Attaching a patch.
Comment 1 Jim Duchek 2007-02-01 22:58:23 UTC
Created attachment 8578 [details] [review]
Fixes bug (see bug)
Comment 2 Daniel Stone 2007-02-27 01:36:08 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 3 Matt Turner 2010-12-03 14:16:11 UTC
Wow, this was fixed in 2007.

commit 024bbc7cbb924daaf3e305ddfc8e74509acd1e15
Author: Eric Anholt <eric@anholt.net>
Date:   Tue Mar 6 16:18:59 2007 -0800

    Bug #9931: Fix linear allocations with a non-1-byte granularity.
    This was introduced in 83080809f9a1c1d24b0318e54632f25f5940da25.  Instead of
    aligning the offset, it doubled it.  Results were appropriately spectacular.

*** This bug has been marked as a duplicate of bug 9931 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.