Bug 97360 - user dbus.socket: Remove [Install] Also=dbus.service
Summary: user dbus.socket: Remove [Install] Also=dbus.service
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.10
Hardware: Other All
: medium normal
Assignee: Jan Alexander Steffens (heftig)
QA Contact: D-Bus Maintainers
Keywords: patch
Depends on:
Reported: 2016-08-16 01:35 UTC by Jan Alexander Steffens (heftig)
Modified: 2016-08-17 06:09 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

[PATCH] user dbus.socket: Remove [Install] Also=dbus.service (1.04 KB, patch)
2016-08-16 01:35 UTC, Jan Alexander Steffens (heftig)
Details | Splinter Review

Description Jan Alexander Steffens (heftig) 2016-08-16 01:35:36 UTC
Created attachment 125807 [details] [review]
[PATCH] user dbus.socket: Remove [Install] Also=dbus.service

When enabling dbus.socket, the cycle between dbus.socket and
dbus.service is broken by ignoring the Also=dbus.socket. Since the
install section of dbus.service is otherwise empty, systemctl then
complains that dbus.service is a static unit.

Break the cycle ourselves by removing Also=dbus.service. The intended
behavior of enabling the socket when enabling the service remains.
Comment 1 Simon McVittie 2016-08-16 09:22:46 UTC
Makes sense.
Comment 2 Simon McVittie 2016-08-16 09:27:25 UTC
Actually, git master already has a fix for Bug #92402, which makes both dbus.service and dbus.socket into static units. Let's do that instead.
Comment 3 Simon McVittie 2016-08-16 09:33:31 UTC
On Bug #92402, I said
> I'm not going to touch how this works in 1.10, because stable branches
> shouldn't contain surprises

How important to you is it that this is fixed in the 1.10 branch? What user-observable bugs, if any, does it cause?

(Note that dbus.socket is already statically enabled, so there is no need for you to enable it again.)

If the bug is only cosmetic, I would be inclined to suggest fixing it in your distro packaging instead.
Comment 4 Jan Alexander Steffens (heftig) 2016-08-17 06:09:21 UTC
You're right. I swapped out this patch downstream for the one from master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.