Bug 97063 - piglit_wfl_framework.c:287:4: error: void function 'parse_test_config' should not return a value [-Wreturn-type]
Summary: piglit_wfl_framework.c:287:4: error: void function 'parse_test_config' should...
Status: RESOLVED FIXED
Alias: None
Product: piglit
Classification: Unclassified
Component: tests (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Piglit Mailing List
QA Contact: Piglit Mailing List
URL:
Whiteboard:
Keywords: bisected, regression
Depends on:
Blocks:
 
Reported: 2016-07-24 06:44 UTC by Vinson Lee
Modified: 2016-07-26 08:35 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments

Description Vinson Lee 2016-07-24 06:44:11 UTC 
piglit: 212f71dcff6cd80a02cc662661385c3de45a4a45 (master)

[  2%] Building C object target_api/gl/tests/util/CMakeFiles/piglitutil_gl.dir/piglit-framework-gl/piglit_wfl_framework.c.o
tests/util/piglit-framework-gl/piglit_wfl_framework.c:287:4: error: void function
      'parse_test_config' should not return a value [-Wreturn-type]
                        return NULL;
                        ^      ~~~~
tests/util/piglit-framework-gl/piglit_wfl_framework.c:469:34: warning: passing
      'int32_t **' (aka 'int **') to parameter of type 'const int32_t **' (aka 'const int **') discards qualifiers in
      nested pointer types [-Wincompatible-pointer-types-discards-qualifiers]
                          partial_config_attrib_list, &attrib_list);
                                                      ^~~~~~~~~~~~
tests/util/piglit-framework-gl/piglit_wfl_framework.c:186:34: note: passing argument to
      parameter 'attrib_list' here
                  const int32_t *attrib_list[])
                                 ^
Comment 1 Vinson Lee 2016-07-25 18:30:44 UTC 
5e78dd43e4b9f7064b194dee1497d0eec7b58d0e is the first bad commit
commit 5e78dd43e4b9f7064b194dee1497d0eec7b58d0e
Author: Emil Velikov <emil.l.velikov@gmail.com>
Date:   Tue Mar 29 23:44:59 2016 +0100

    util/wfl: fold make_config_attrib_list and make_context_description
    
    The latter tends to reverse what was done by the former, in order to
    produce a human-readable string.
    
    Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
    Reviewed-by: Jose Fonseca <jfonseca@vmware.com>

:040000 040000 ce09f827510b07126574dad1b0fc2f74f046f875 672a93fd68e325e8c5e4192eb45823d6325461f0 M	tests
bisect run success
Comment 2 Emil Velikov 2016-07-26 08:35:46 UTC 
Thanks Vinson. These should be fixed with the following

commit 3cdff435cdbafefd557d542f1b96feab3047fbf6
Author: Emil Velikov <emil.velikov@collabora.com>
Date:   Mon Jul 25 11:41:59 2016 +0100

    util/wfl: remove const qualifier from parse_test_config

commit 5221c65d10e06252022dacd245b4836c15d341d2
Author: Emil Velikov <emil.velikov@collabora.com>
Date:   Mon Jul 25 11:36:26 2016 +0100

    util/wfl: remove unused default case

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.