Bug 94738 - remote-viewer not saving last monitor config
Summary: remote-viewer not saving last monitor config
Status: RESOLVED FIXED
Alias: None
Product: Spice
Classification: Unclassified
Component: spice-gtk (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Pavel Grunt
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2016-03-29 11:32 UTC by Victor Toso
Modified: 2016-03-29 15:55 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
log (78.39 KB, text/plain)
2016-03-29 11:32 UTC, Victor Toso 		Details
View All

Description Victor Toso 2016-03-29 11:32:27 UTC 
Created attachment 122610 [details]
log

* I have a rhel7 guest in a rhel7 host (but upstream qemu on the host)
* When connecting with upstream remote-viewer (and upstream spice-gtk) it has opened 4 display widgets but only 1 enable.

I've connected with virt-viewer from rhel7 and it showed correctly one display. For testing purposes, I've enable the second display with virt-viewer and tried again with upstream remote-viewer: The result is 4 displays with 2 enabled.

SPICE_DEBUG=1 log is attached.
Comment 1 Pavel Grunt 2016-03-29 12:36:04 UTC 
Regression since 962ebf97e706df657793c45cfe58b1f17f3abb38

We need to distinguished between Virgil and non-Virgil guest. When the egl.enabled is TRUE and the guest is not using Virgil it is needed to check for the display mark
Comment 2 Pavel Grunt 2016-03-29 12:45:12 UTC 
(In reply to Pavel Grunt from comment #1)
> Regression since 962ebf97e706df657793c45cfe58b1f17f3abb38
> 
> We need to distinguished between Virgil and non-Virgil guest. When the
> egl.enabled is TRUE and the guest is not using Virgil it is needed to check
> for the display mark

or just use () around the ternary

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.