Bug 92957 - [Patch] VIASave and VIARestore Functions Complete Rewrite
Summary: [Patch] VIASave and VIARestore Functions Complete Rewrite
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/openchrome (show other bugs)
Version: unspecified
Hardware: x86 (IA32) Linux (All)
: medium enhancement
Assignee: Openchrome development list
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-15 06:11 UTC by Kevin Brace
Modified: 2016-05-20 17:32 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
This patch completely rewrites VIASave and VIARestore functions. (40.72 KB, text/plain)
2015-11-15 06:11 UTC, Kevin Brace
no flags Details
This patch completely rewrites VIASave and VIARestore functions (39.94 KB, patch)
2015-12-04 05:28 UTC, Kevin Brace
no flags Details | Splinter Review

Description Kevin Brace 2015-11-15 06:11:42 UTC
Created attachment 119669 [details]
This patch completely rewrites VIASave and VIARestore functions.

Completely rewrites VIASave and VIARestore functions inside via_vgahw.c.
It now saves and restores virtually all VIA Technologies defined 
extended VGA registers. The previous code did not save all extended VGA 
registers, so many registers were not being restored at all.
That being said, Chrome 9 HD HDMI or DisplayPort registers are not 
being saved or restored in this patch.
    The compiled device driver was tested on the following computer.

 - Epic 1314 laptop (MSI VR321 laptop equivalent, VN896 chipset) 
   with Lubuntu 12.04 i386
Comment 1 Kevin Brace 2015-12-04 05:28:33 UTC
Created attachment 120322 [details] [review]
This patch completely rewrites VIASave and VIARestore functions

Completely rewrites VIASave and VIARestore functions inside via_vgahw.c.
It now saves and restores virtually all VIA Technologies defined extended VGA registers.
The previous code did not save all extended VGA registers, so many registers were not being restored at all.
That being said, Chrome 9 HD HDMI or DisplayPort registers are not being saved or restored since they cannot be accessed via VGA I/O ports.
    The compiled device driver was tested on the following computer.

 - Epic 1314 laptop (MSI VR321 laptop equivalent, VN896 chipset)
   with Lubuntu 12.04 i386
Comment 2 Kevin Brace 2016-05-20 17:32:26 UTC
Fixed by commit 0d3c0deb72f5cce55be18bdf89e389eb4df71e13.

https://cgit.freedesktop.org/openchrome/xf86-video-openchrome/commit/?id=0d3c0deb72f5cce55be18bdf89e389eb4df71e13


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.