Bug 92264 - [softpipe] piglit arb_direct_state_access-texunits regression
Summary: [softpipe] piglit arb_direct_state_access-texunits regression
Status: RESOLVED DUPLICATE of bug 92215
Alias: None
Product: Mesa
Classification: Unclassified
Component: Mesa core (show other bugs)
Version: git
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: mesa-dev
QA Contact: mesa-dev
Keywords: bisected, regression
Depends on:
Reported: 2015-10-03 02:15 UTC by Vinson Lee
Modified: 2015-10-03 02:17 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Description Vinson Lee 2015-10-03 02:15:42 UTC
mesa: bf7b6fd3fd6d98305d64ee6224ca9f9e7ba48444 (master 11.1.0-devel)

$ ./bin/arb_direct_state_access-texunits -auto 
GL_RENDERER = Gallium 0.4 on softpipe
Mesa: User error: GL_INVALID_VALUE in glBindTextureUnit(unit=54)
Unexpected GL error: GL_INVALID_VALUE 0x501
(Error at piglit/tests/spec/arb_direct_state_access/texunits.c:124)
Expected GL error: GL_INVALID_OPERATION 0x502
PIGLIT: {"result": "fail" }

a9408f3ca14f2fb6286bd66bad06ee1bde0d8697 is the first bad commit
commit a9408f3ca14f2fb6286bd66bad06ee1bde0d8697
Author: Brian Paul <brianp@vmware.com>
Date:   Wed Sep 30 11:37:16 2015 -0600

    mesa: remove _mesa_get_tex_unit_err() and fix error handling
    This helper was only called from _mesa_BindTextureUnit().  It's simpler
    to just inline it.
    The error check / code / message in the helper was incorrect.  It was
    written for glBindTextures(), not glBindTextureUnit().  The correct
    error for a bad texture unit number is GL_INVALID_VALUE.  The error
    message now reports the unit number rather than a GL_TEXTUREi enum.
    Fixes a failure in piglit's arb_direct_state_access-bind-texture-unit test.
    Reviewed-by: Tapani Pälli <tapani.palli@intel.com>

:040000 040000 7d921525c01aef94abfb26cc232d225ebe5f50af 27e5bf59206f1906b3654aa6da59d70968234f6c M	src
bisect run success
Comment 1 Tapani Pälli 2015-10-03 02:17:43 UTC

*** This bug has been marked as a duplicate of bug 92215 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.