Bug 89826 - [PATCH] dbus-specification: fix GetConnectionCredentials description
Summary: [PATCH] dbus-specification: fix GetConnectionCredentials description
Status: RESOLVED NOTABUG
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: git master
Hardware: All All
: medium normal
Assignee: D-Bus Maintainers
QA Contact: D-Bus Maintainers
URL:
Whiteboard: review-
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-03-30 15:03 UTC by Lukasz Skalski
Modified: 2015-04-28 11:01 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
[PATCH] dbus-specification: fix GetConnectionCredentials description (1.23 KB, patch)
2015-03-30 15:05 UTC, Lukasz Skalski
Details | Splinter Review

Description Lukasz Skalski 2015-03-30 15:03:25 UTC
GetConnectionCredentials method returns a{sv} - ARRAY of DICT<STRING,VARIANT>, not {sv} as it described in dbus-specification.xml
Comment 1 Lukasz Skalski 2015-03-30 15:05:49 UTC
Created attachment 114729 [details] [review]
[PATCH] dbus-specification: fix GetConnectionCredentials  description
Comment 2 Simon McVittie 2015-03-31 10:19:43 UTC
(In reply to Lukasz Skalski from comment #0)
> GetConnectionCredentials method returns a{sv} - ARRAY of
> DICT<STRING,VARIANT>, not {sv} as it described in dbus-specification.xml

No, it returns a{sv}, "DICT<STRING,VARIANT>", which is shorthand for ARRAY<DICT_ENTRY<STRING,VARIANT>> (please note the distinction between a dict and a dict-entry). GetAll() on the Properties interface is the same.

Conceptually, the common "dict" pattern is just like a dict in Python: it takes 0 or more key/value pairs. In the wire protocol we use an ARRAY<DICT_ENTRY<k,v>> to represent that pattern.

I'd review a patch to clarify that a dict is synonymous with an array of dict-entries, but Attachment #114729 [details] is not correct.
Comment 3 Lukasz Skalski 2015-04-28 11:01:02 UTC
Thanks for clarification. I've just changed status to NOTABUG.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.