Bug 89428 - avoid implicit declarations on mingw
Summary: avoid implicit declarations on mingw
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: D-Bus Maintainers
URL:
Whiteboard: review?
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-03-04 18:52 UTC by Simon McVittie
Modified: 2015-03-05 13:31 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
dbus-monitor: use _dbus_get_real_time instead of gettimeofday (1.76 KB, patch)
2015-03-04 18:53 UTC, Simon McVittie
Details | Splinter Review
dbus-print-message: conditionalize Unix FD handling on DBUS_UNIX (1.08 KB, patch)
2015-03-04 18:53 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2015-03-04 18:52:03 UTC
The mingw build currently has a couple of implicit-declaration warnings for Unixisms.
Comment 1 Simon McVittie 2015-03-04 18:53:11 UTC
Created attachment 114003 [details] [review]
dbus-monitor: use _dbus_get_real_time instead of  gettimeofday

gettimeofday is implicitly declared (i.e. not in our #include'd header
files) when cross-compiling for on Windows. Now that fd.o#83115
has been fixed, using _dbus functions is not a problem.
Comment 2 Simon McVittie 2015-03-04 18:53:36 UTC
Created attachment 114004 [details] [review]
dbus-print-message: conditionalize Unix FD handling on  DBUS_UNIX

We close() the fd after we have printed it, but close() isn't
standard functionality on Windows. Unix FD-passing is never going
to work on non-Unix platforms anyway.
Comment 3 Ralf Habacker 2015-03-04 19:38:41 UTC
Comment on attachment 114003 [details] [review]
dbus-monitor: use _dbus_get_real_time instead of  gettimeofday

Review of attachment 114003 [details] [review]:
-----------------------------------------------------------------

looks good
Comment 4 Ralf Habacker 2015-03-04 19:39:27 UTC
Comment on attachment 114004 [details] [review]
dbus-print-message: conditionalize Unix FD handling on  DBUS_UNIX

Review of attachment 114004 [details] [review]:
-----------------------------------------------------------------

looks good
Comment 5 Simon McVittie 2015-03-05 13:31:39 UTC
Thanks, fixed in git for 1.9.16


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.