Bug 87513 - NameError: name 'dirname' is not defined
Summary: NameError: name 'dirname' is not defined
Alias: None
Product: piglit
Classification: Unclassified
Component: tests (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium blocker
Assignee: Piglit Mailing List
QA Contact: Piglit Mailing List
Keywords: bisected, regression
Depends on:
Reported: 2014-12-19 23:46 UTC by Vinson Lee
Modified: 2014-12-20 00:07 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Description Vinson Lee 2014-12-19 23:46:27 UTC
piglit: 688294703e580c2d9b77e814cdd3ae68d96c57a3 (master)

[ 99%] Generating cl_store_tests.list
Traceback (most recent call last):
  File "generated_tests/generate-cl-store-tests.py", line 35, in <module>
NameError: name 'dirname' is not defined

commit 688294703e580c2d9b77e814cdd3ae68d96c57a3
Author: Dylan Baker <dylanx.c.baker@intel.com>
Date:   Wed Dec 17 15:28:59 2014 -0800

    generated_tests: Actually catch exception in os.makedirs
    Patch b59ff71eb was supposed to fix os.makedirs exceptions, but falls
    short because of a missing else statement that causes all of the caught
    exceptions to fall back to raise.
    This corrects, it also pulls the duplicate functions out into a shared
    v2: - remove accidentally included hunk (Mark)
    v3: - Actually include the modules directory in the commit (Mark)
    Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>
    Reviewed-by: Mark Janes <mark.a.janes@intel.com>
Comment 1 Dylan Baker 2014-12-19 23:50:49 UTC
copy and paste error. I'll fix it imediately.
Comment 2 Dylan Baker 2014-12-19 23:55:17 UTC
There is a patch on the list for this:

"generate-cl-store-tests.py: fix copy and paste error from 68829470"
Comment 3 Dylan Baker 2014-12-20 00:07:31 UTC
6882947..f48cfa9  master -> master

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.