Bug 87439 - EDITING: Pressing enter in a table doesnt adjust cell height
Summary: EDITING: Pressing enter in a table doesnt adjust cell height
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.2.6.2 release
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks:
 
Reported: 2014-12-18 12:11 UTC by Yousuf Philips (jay) (retired)
Modified: 2015-12-15 11:03 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2014-12-18 12:11:53 UTC
Steps:
1) Open impress
2) Add a table
3) In a cell press enter
4) Notice that the cursor moves down but the cell height doesnt change

Alternative steps:
1) Open impress
2) Add a table
3) In a cell type more words that can fill the cells width
4) Notice the cell height doesnt change when the text wraps to the second line

Regression as it worked correctly in 4.1.6. It is broken in 4.2.6 and 4.3.daily and fixed in 4.4/master.

Version: 4.3.4.0.0+
Build ID: 81e4dbe1adf196ee20f1a4bfbc50b54abfc79f4b
TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:libreoffice-4-3, Time: 2014-10-27_14:09:41

Version: 4.5.0.0.alpha0+
Build ID: e570cd7a293ceee175949dcc9656cdf776ae3c37
TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2014-12-12_18:49:54
Comment 1 Yousuf Philips (jay) (retired) 2014-12-18 12:13:44 UTC
Confirming this as it was reported on twitter.

https://twitter.com/AlainODea/status/545300839364308993
Comment 2 Rostislav 'R.Yu.' Okulov 2014-12-19 08:53:02 UTC
I did bibisect just to clean bibisect requestlist.

git bisect log
git bisect start
# bad: [423a84c4f7068853974887d98442bc2a2d0cc91b] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
git bisect bad 423a84c4f7068853974887d98442bc2a2d0cc91b
# good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00] source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932
git bisect good 65fd30f5cb4cdd37995a33420ed8273c0a29bf00
# good: [e02439a3d6297a1f5334fa558ddec5ef4212c574] source-hash-6b8393474974d2af7a2cb3c47b3d5c081b550bdb
git bisect good e02439a3d6297a1f5334fa558ddec5ef4212c574
# good: [4850941efe43ae800be5c76e1102ab80ac2c085d] source-hash-980a6e552502f02f12c15bfb1c9f8e6269499f4b
git bisect good 4850941efe43ae800be5c76e1102ab80ac2c085d
# good: [a900e72b6357882284c5955bdf939bf14269f5fb] source-hash-dd1050b182260a26a1d0ba6d0ef3a6fecc3f4e07
git bisect good a900e72b6357882284c5955bdf939bf14269f5fb
# skip: [e80660c5a1d812cd04586dae1f22767fc3778c4a] source-hash-07c60c8ee2d1465544a6a39e57bc06b3690b8dfb
git bisect skip e80660c5a1d812cd04586dae1f22767fc3778c4a
# bad: [df9bcaed2faa2a8d11b19f877cdff3a12a887278] source-hash-6ba9692d8bbe3e3c245aca9a7c928e81178d05f1
git bisect bad df9bcaed2faa2a8d11b19f877cdff3a12a887278
# bad: [9d57c189d74551d2b3770cc81139ea10a62e672f] source-hash-5b5e62650354788e50b44f32c22b687b2018aba9
git bisect bad 9d57c189d74551d2b3770cc81139ea10a62e672f
# good: [ce81582766413e76a63c047bfd6227ab12fcd866] source-hash-3d1b1eea83703919c43620f9adef05e5b24c4bed
git bisect good ce81582766413e76a63c047bfd6227ab12fcd866
# good: [87bfccc81c2d8028642492b80505217d7b42a5a8] source-hash-5b4b6b2aad548cdc27ba2aa7d87ff584ec7e97dd
git bisect good 87bfccc81c2d8028642492b80505217d7b42a5a8
# bad: [1b831d02ff29aa5763cf33ae75131f98d882201f] source-hash-b7c3e851465638d4416ca8837937946353561088
git bisect bad 1b831d02ff29aa5763cf33ae75131f98d882201f
# skip: [524032d94d92022e87e0add99aea74683da8f368] source-hash-c7363cb6d1d31f2a7d40a76e62b5934629a1a8a1
git bisect skip 524032d94d92022e87e0add99aea74683da8f368
# skip: [f832455cd2cc194ff04197ef174cb1e658336d18] source-hash-a79afdaa11a1af26c9404441dcf27ef197e972b2
git bisect skip f832455cd2cc194ff04197ef174cb1e658336d18
# only skipped commits left to test
# possible first bad commit: [1b831d02ff29aa5763cf33ae75131f98d882201f] source-hash-b7c3e851465638d4416ca8837937946353561088
# possible first bad commit: [f832455cd2cc194ff04197ef174cb1e658336d18] source-hash-a79afdaa11a1af26c9404441dcf27ef197e972b2
# possible first bad commit: [524032d94d92022e87e0add99aea74683da8f368] source-hash-c7363cb6d1d31f2a7d40a76e62b5934629a1a8a1


There are only 'skip'ped commits left to test.
The first bad commit could be any of: 524032d94d92022e87e0add99aea74683da8f368 f832455cd2cc194ff04197ef174cb1e658336d18 1b831d02ff29aa5763cf33ae75131f98d882201f
We cannot bisect more!
Comment 3 Matthew Francis 2014-12-23 13:10:57 UTC
This is fixed on master in the following commit, which has also already been applied to 4.3. I confirm 4.3.5.1 to be fixed.

commit 22ef69b25fa60f4543dc72cb7a8d2f88b789ce43
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Thu Nov 13 14:31:09 2014 +0000

    impress tables are not interactively growing
    
    the optimization here stops tables growing as their text
    contents change in editing mode
    
    So, just recalculate if the table could grow and its
    being interactively edited, which leaves the original
    (dubious ?) load-time optimization in place
    
    Change-Id: I894acf47d34ec8b68aaf9076b5a0cb7e29c38a17
Comment 4 Yousuf Philips (jay) (retired) 2014-12-23 15:39:05 UTC
Thanks Matthew and RYu.
Comment 5 Robinson Tryon (qubit) 2014-12-29 21:41:20 UTC
Fixed in 4.3, and 4.2 is EOL, so removing 'fixedInMaster' from the Whiteboard.
Comment 6 Robinson Tryon (qubit) 2015-12-15 11:03:32 UTC
Migrating Whiteboard tags to Keywords: (bibisected)
[NinjaEdit]