Bug 8590 - automatic version numbers (courtesy of autoconf)
Summary: automatic version numbers (courtesy of autoconf)
Status: RESOLVED FIXED
Alias: None
Product: xorg
Classification: Unclassified
Component: Build/Modular (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 8737
  Show dependency treegraph
 
Reported: 2006-10-10 12:43 UTC by Andres Salomon
Modified: 2006-11-30 13:59 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
first patch I proposed (1.27 KB, patch)
2006-10-10 12:43 UTC, Andres Salomon
no flags Details | Splinter Review
second patch I proposed (1.40 KB, patch)
2006-10-10 12:44 UTC, Andres Salomon
no flags Details | Splinter Review
third patch I proposed (1.35 KB, patch)
2006-10-10 12:44 UTC, Andres Salomon
no flags Details | Splinter Review

Description Andres Salomon 2006-10-10 12:43:06 UTC
There's no standard method for setting the major,
minor, and patchlevel versions in each module.  Some hardcode the
versions via #defines; others base them on the autoconf-defined value of
PACKAGE_VERSION.

It would make a lot more sense to have autoconf handle defining these,
and base it off PACKAGE_VERSION (for those who don't do much autoconf,
PACKAGE_NAME and PACKAGE_VERSION are automatically set in config.h based
on the values passed to AC_INIT() in configure.ac).  The variable names
I've chosen to go w/ are PACKAGE_VERSION_MAJOR, PACKAGE_VERSION_MINOR,
and PACKAGE_VERSION_PATCHLEVEL.

I've described the problem, proposed patches, gotten feedback, and revised the
patches here:

http://lists.freedesktop.org/archives/xorg/2006-October/018505.html
Comment 1 Andres Salomon 2006-10-10 12:43:54 UTC
Created attachment 7329 [details] [review]
first patch I proposed
Comment 2 Andres Salomon 2006-10-10 12:44:18 UTC
Created attachment 7330 [details] [review]
second patch I proposed
Comment 3 Andres Salomon 2006-10-10 12:44:57 UTC
Created attachment 7331 [details] [review]
third patch I proposed
Comment 4 Andres Salomon 2006-11-23 20:37:55 UTC
Any chance of getting this committed in time for the 7.2 release?
Comment 5 Daniel Stone 2006-11-30 13:59:07 UTC
util-macros 1.1.3 pushed, thanks


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.