piglit: b13d0bb86d175e36e013dbd528a50e59308adad0 (master)
Build error with MSVC 2012.
tests\shaders\shader_runner.c(1209) : warning C4013: 'strtoll' undefined; assuming extern returning int
Linking CXX executable ..\..\..\..\bin\shader_runner.exe
shader_runner.c.obj : error LNK2019: unresolved external symbol _strtoll referenced in function _get_doubles
Build error introduced with commit d859c94fd1d0406c3d109ed209897baccf99b57d.
Author: Ian Romanick <email@example.com>
Date: Wed Sep 3 18:38:08 2014 -0700
shader_runner: Allow loading hex values for floats
For some cases we want to have shaders where we load an exact bit
pattern into a float (or double) uniform.
NOTE: The double path isn't really tested.
Signed-off-by: Ian Romanick <firstname.lastname@example.org>
Reviewed-by: Chris Forbes <email@example.com>
I'm building with MSVC 2013 and it builds fine.
Unless you have a strong need to build with MSVC 2012, I'd rather make MSVC 2013 a requirement to build piglit, instead of worrying with older MSVC versions.
MSVC 2013 has better C99, so there's less portability hacks need. I don't even try building with MSVC 2012 anymore.
Could you build with MSVC 2013 instead?
I sent out a patch:
But it sounds like that will have problems with later MSVC.
> Could you build with MSVC 2013 instead?
(In reply to José Fonseca from comment #4)
> > Could you build with MSVC 2013 instead?
I can successfully build piglit with MSVC 2013.
(In reply to Vinson Lee from comment #5)
> (In reply to José Fonseca from comment #4)
> > > Could you build with MSVC 2013 instead?
> I can successfully build piglit with MSVC 2013.
Great. In that case I'm going to update piglit's cmake files to require MSVC 2013 henceforth.
As of commit 6927659f5fc484a40a13028edab99eb33264fad8 MSVC 2012 is required to build piglit.
So we can resolve this now.