Bug 85106 - dbus-daemon-launch-helper: log to syslog on failure
Summary: dbus-daemon-launch-helper: log to syslog on failure
Status: RESOLVED MOVED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.8
Hardware: Other All
: low enhancement
Assignee: D-Bus Maintainers
QA Contact: D-Bus Maintainers
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2014-10-16 19:27 UTC by Simon McVittie
Modified: 2018-10-12 21:21 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
dbus-daemon-launch-helper: on failure, log it to system log before exiting (1.42 KB, patch)
2014-10-16 19:28 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2014-10-16 19:27:59 UTC
In simple cases, dbus-daemon-launch-helper's exit status is enough that, with Bug #24821 fixed, you can diagnose issues.

In more complex cases, having the DBusError.message would be more helpful.
Comment 1 Simon McVittie 2014-10-16 19:28:52 UTC
Created attachment 107946 [details] [review]
dbus-daemon-launch-helper: on failure, log it to system log  before exiting

The communication channel between the launch helper and the dbus-daemon
is rather limited, so any extra hints are welcome.

---

We should probably introduce a new log level that isn't AUTHPRIV so it goes to the normal syslog instead of auth.log, or use LOG_INFO, or something. Thoughts?
Comment 2 Simon McVittie 2014-10-16 19:29:53 UTC
Note that this is in security-sensitive (setuid) code. If we couldn't safely call openlog() and syslog() in security-sensitive code, I suspect a lot of privileged processes would already be doomed, notably sudo... but it does increase the attack surface.
Comment 3 GitLab Migration User 2018-10-12 21:21:33 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/dbus/dbus/issues/115.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.