Bug 8459 - wfb merge broke xserver
Summary: wfb merge broke xserver
Alias: None
Product: xorg
Classification: Unclassified
Component: Server/General (show other bugs)
Version: git
Hardware: Other Linux (All)
: high major
Assignee: Aaron Plattner
QA Contact:
Keywords: regression
Depends on:
Reported: 2006-09-29 07:51 UTC by Marcin Kurek
Modified: 2009-01-02 14:12 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Log from faulty start (47.97 KB, text/plain)
2006-09-29 07:52 UTC, Marcin Kurek
no flags Details
Proposed fix (770 bytes, patch)
2006-10-09 16:33 UTC, Aaron Plattner
no flags Details | Splinter Review

Description Marcin Kurek 2006-09-29 07:51:22 UTC
It seems one of the recent git commits broke xserver on my setup. The faulty
commit is Merge branch 'wfb' (4bc5dc2854e33bf343cdea44a3c3b4c41f6f4145) With
this change xserver crash at startup and lockups the machine reverting fix problem.
Comment 1 Marcin Kurek 2006-09-29 07:52:43 UTC
Created attachment 7195 [details]
Log from faulty start
Comment 2 Marcin Kurek 2006-09-30 02:15:20 UTC
Forgot to mention. This is on Pegasos II machine with 1GHz G4 CPU and Radeon
9000 64MB/128bit/VIVO/DVI
Comment 3 Marcin Kurek 2006-10-05 15:34:17 UTC
A small update to the report. Today I installed recent xorg-server on my
girlfriend machine and it seems the problem is not present here.

Pentium 4 machine with 512MB of RAM and Radeon 9200 card.
Comment 4 Michel Dänzer 2006-10-08 15:40:47 UTC
I can confirm this on a PowerBook. Aaron, any idea which part(s) of your changes
might break on big endian (or possibly when char is unsigned by default)?
Comment 5 Aaron Plattner 2006-10-08 21:46:53 UTC
No, the new macros were supposed to be a no-op for libfb.  Where exactly is it
crashing in AllocateWindowPrivate?
Comment 6 Aaron Plattner 2006-10-09 16:33:38 UTC
Created attachment 7313 [details] [review]
Proposed fix

Automake is too smart for me.  Does the attached patch fix the problem for you?
Comment 7 Matthieu Herrb 2006-10-10 14:16:53 UTC
It fixes the problem for me on an x86 machine.
Comment 8 Aaron Plattner 2006-10-10 14:23:24 UTC
Cool.  Marking fixed.

commit 042d4a407d0eca9131d0420b0b9189559aac326d
Author: Aaron Plattner <aplattner@nvidia.com>
Date:   Mon Oct 9 16:32:11 2006 -0700

    Bug #8459: Don't forget to include AM_CFLAGS in libfb_la_CFLAGS on non-MMX
    Reported by Edgar Toernig.

:100644 100644 9a56b93... 1649669... M  fb/Makefile.am
Comment 9 Sergey V. Udaltsov 2009-01-02 14:12:01 UTC
*** Bug 17184 has been marked as a duplicate of this bug. ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.