We found a file descriptor leak (no close-on-exec set) from D-Bus.
I also noticed that many places in the code uses close() instead of
_dbus_close() -- that's bad because then EINTR is not handled.
Attaching the patch.
Note: I made the patch originally for 0.62, so it might miss something in the
Created attachment 6865 [details] [review]
Created attachment 6866 [details] [review]
another patch for missing fclose()
here is another patch for missing fclose(), although it does not have
Created attachment 6867 [details] [review]
plug another FD leak in dbus-spawn.c
Ok, here is the last FD leak plugged. Now activated services don't inherit
Committed patches 1 and 3. Patch 2 no longer applies because of the sysdep
split for unix and windows. Can you regenerate the patch with the
--show-c-function flag. Thanks.
(In reply to comment #4)
> Committed patches 1 and 3. Patch 2 no longer applies because of the sysdep
> split for unix and windows. Can you regenerate the patch with the
> --show-c-function flag. Thanks.
Is there a tarball available for the trunk? (I have problem with CVS because of
the company firewall...)
If I just know what the methods are you are changing I can manually apply the patch.
Found the function. Closing