+dist_gir_DATA = Wocky-1.gir

Why is this distributed in tarballs? (If there's no good reason, don't.)

+CLEANFILES += \
+ $(dist_gir_DATA) \

Please don't delete distributed files in "make clean".

> introspect all files

Can we use some variables rather than duplicating the file list?

Telepathy officially requires GNU make, so $(patsubst %,$(srcdir)/%,$(some_SOURCES)) is OK.

Looks good other than that.

(In reply to comment #1)
> +dist_gir_DATA = Wocky-1.gir
> 
> Why is this distributed in tarballs? (If there's no good reason, don't.)

> +CLEANFILES += \
> + $(dist_gir_DATA) \
> 
> Please don't delete distributed files in "make clean".

I just cargo-culted introspection.am from tp-glib. Tartan needs the gir files to be installed but I guess we could not distribute it for now and tweak GI_TYPELIB_PATH manually.

> > introspect all files
> 
> Can we use some variables rather than duplicating the file list?
> 
> Telepathy officially requires GNU make, so $(patsubst
> %,$(srcdir)/%,$(some_SOURCES)) is OK.

I considered using "Wocky_1_gir_FILES = $(libwocky_la_SOURCES)" which worked but that included -internal and -protected headers, which may be ok for now tbh.

(In reply to comment #3)
> I considered using "Wocky_1_gir_FILES = $(libwocky_la_SOURCES)" which worked
> but that included -internal and -protected headers, which may be ok for now
> tbh.

You can use #ifndef __GI_SCANNER__ to hide those, if you need to.

gtk-doc's /*<private_header>*/ rune might also work.

(In reply to comment #4)
> (In reply to comment #3)
> > I considered using "Wocky_1_gir_FILES = $(libwocky_la_SOURCES)" which worked
> > but that included -internal and -protected headers, which may be ok for now
> > tbh.
> 
> You can use #ifndef __GI_SCANNER__ to hide those, if you need to.
> 
> gtk-doc's /*<private_header>*/ rune might also work.

Ah good idea! I've done that.

What's your opinion regarding distributing the gir file or not?