Bug 73475 - <allow_anonymous/> is functionally ignored when appearing in included config files
Summary: <allow_anonymous/> is functionally ignored when appearing in included config ...
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: All All
: medium normal
Assignee: Havoc Pennington
QA Contact:
URL:
Whiteboard: review?
Keywords: patch
Depends on:
Blocks:
 
Reported: 2014-01-10 14:49 UTC by Matt Hoosier
Modified: 2014-01-14 11:18 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
Propagate <allow_anonymous/> correctly (830 bytes, patch)
2014-01-10 14:49 UTC, Matt Hoosier 		Details | Splinter Review
View All

Description Matt Hoosier 2014-01-10 14:49:16 UTC 
Created attachment 91819 [details] [review]
Propagate <allow_anonymous/> correctly

The algorithm which merges configs parsed from subsidiary files (e.g., system-local.conf) into the master BusConfigParser instance, forgets to propagate the value of the 'allow_anonymous' field from an included file up to the parent file.

The has the effect of making it impossible to write:

  <busconfig>
    <allow_anonymous/>
  </busconfig>

from an <included>'ed file.

A fix is attached.
Comment 1 Chengwei Yang 2014-01-13 06:29:36 UTC 
Comment on attachment 91819 [details] [review]
Propagate <allow_anonymous/> correctly

Review of attachment 91819 [details] [review]:
-----------------------------------------------------------------

Looks good to me.
Comment 2 Simon McVittie 2014-01-14 11:18:12 UTC 
Fixed in git for 1.7.12 (or 1.8.0), thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.