Bug 73321 - [PATCH] configure: GNOME_COMMON_INIT: command not found
Summary: [PATCH] configure: GNOME_COMMON_INIT: command not found
Status: RESOLVED FIXED
Alias: None
Product: udisks
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: All Linux (All)
: medium critical
Assignee: David Zeuthen (not reading bugmail)
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2014-01-06 12:43 UTC by Yevhen Kyriukha
Modified: 2014-12-18 08:55 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
Patch (639 bytes, text/plain)
2014-01-06 12:43 UTC, Yevhen Kyriukha
Details
0001-Do-not-use-deprecated-GNOME_.patch (752 bytes, patch)
2014-03-15 00:51 UTC, David Heidelberg (okias)
Details | Splinter Review

Description Yevhen Kyriukha 2014-01-06 12:43:43 UTC
Created attachment 91539 [details]
Patch

I get an error during configure stage:
GNOME_COMMON_INIT: command not found

That's because GNOME_COMMON_INIT is deprecated and should be removed from configure.ac.

I've attached a patch that fixes this issue.
Comment 1 David Heidelberg (okias) 2014-03-15 00:51:30 UTC
Created attachment 95838 [details] [review]
0001-Do-not-use-deprecated-GNOME_.patch

Well, I'd like to drop all GNOME_ things, because they fail all. All marked as deprecated.

I created patch, based on yours, which drops all 4 lines of GNOME_
Comment 2 David Heidelberg (okias) 2014-03-27 18:00:43 UTC
more than 2 months since first reported
Comment 3 Philip Withnall 2014-05-02 13:51:08 UTC
(In reply to comment #1)
> Created attachment 95838 [details] [review] [review]
> 0001-Do-not-use-deprecated-GNOME_.patch
> 
> Well, I'd like to drop all GNOME_ things, because they fail all. All marked
> as deprecated.
> 
> I created patch, based on yours, which drops all 4 lines of GNOME_

Removing GNOME_COMMON_INIT is correct because it’s deprecated and (critically) the ACLOCAL_AMFLAGS variable it sets is already correctly set in Makefile.am

Removing GNOME_MAINTAINER_MODE_DEFINES is also correct because it’s also deprecated.

Removing GNOME_DEBUG_CHECK is correct because it’s not used (it defines GNOME_ENABLE_DEBUG which is not used in the C).

Removing GNOME_COMPILE_WARNINGS is *not* correct because that will disable a huge number of compilation warnings when building the code. The correct fix here is for you to install gnome-common. It is a required build dependency of udisks.
Comment 4 Martin Pitt 2014-12-18 08:55:29 UTC
Fixed in http://cgit.freedesktop.org/udisks/commit/?id=06de19f8dfc


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.