Bug 70991 - [1.0] import old "Telepathy 0" accounts, with migration if necessary
Summary: [1.0] import old "Telepathy 0" accounts, with migration if necessary
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: mission-control (show other bugs)
Version: git master
Hardware: Other All
: medium enhancement
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard: review?
Keywords: patch
Depends on: 49737
Blocks: 68660 76685
  Show dependency treegraph
 
Reported: 2013-10-29 11:18 UTC by Simon McVittie
Modified: 2014-04-03 14:39 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
1/4] McdAccountManagerDefault: copy accounts from Telepathy 0 on first run (9.11 KB, patch)
2014-03-20 16:25 UTC, Simon McVittie
Details | Splinter Review
[2/4] mcd_account_delete_async: remove #if 0 code to delete old account storage (1.77 KB, patch)
2014-03-20 16:25 UTC, Simon McVittie
Details | Splinter Review
3/4] McdAccount: reinstate avatar-migration code, considerably simplified (9.41 KB, patch)
2014-03-20 16:25 UTC, Simon McVittie
Details | Splinter Review
4/4] Re-enable regression tests for account import, and add more (12.37 KB, patch)
2014-03-20 16:26 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2013-10-29 11:18:35 UTC
My plan for MC 6 parallel-installability in Bug #49737 is that it will initially have an entirely separate set of accounts.

Once we have that working, we can give it logic to do a one-time-only copy of "Telepathy 0" (MC 5) accounts. This is also a good opportunity to do any migration steps that we want to do:

* rename 'account' parameter to 'username' if we decide to do that
* turn 'sofiasip' accounts into 'rakia' accounts
Comment 1 Simon McVittie 2014-02-07 14:32:18 UTC
(In reply to comment #0)
> This is also a good opportunity to do any
> migration steps that we want to do:

* rename parameters that are also D-Bus properties from o.fd.T.blahblah to im.telepathy.v1.blahblah
Comment 2 Simon McVittie 2014-02-07 14:38:48 UTC
(In reply to comment #0)
> This is also a good opportunity to do any
> migration steps that we want to do:

* maybe change IRC 'account' into Nickname?
Comment 3 Simon McVittie 2014-03-20 16:24:33 UTC
(In reply to comment #0)
> This is also a good opportunity to do any
> migration steps that we want to do

None implemented yet. I think they could go in migrate_accounts() in mcd-account-manager.c, tbh.
Comment 4 Simon McVittie 2014-03-20 16:25:06 UTC
Created attachment 96107 [details] [review]
1/4] McdAccountManagerDefault: copy accounts from Telepathy 0  on first run
Comment 5 Simon McVittie 2014-03-20 16:25:33 UTC
Created attachment 96108 [details] [review]
[2/4] mcd_account_delete_async: remove #if 0 code to delete old  account storage

We're not going to delete Telepathy-0 account data in Telepathy-1.
Comment 6 Simon McVittie 2014-03-20 16:25:46 UTC
Created attachment 96109 [details] [review]
3/4] McdAccount: reinstate avatar-migration code, considerably  simplified

We no longer want to delete the directories containing old filenames
(all old directories that we currently support are owned by Telepathy-0
and should not be deleted).
Comment 7 Simon McVittie 2014-03-20 16:26:29 UTC
Created attachment 96110 [details] [review]
4/4] Re-enable regression tests for account import, and add  more
Comment 8 Simon McVittie 2014-04-03 14:39:02 UTC
Fixed in git for 0.99.10


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.