Bug 70152 - overrun.c(64) : error C2036: 'const void *' : unknown size
Summary: overrun.c(64) : error C2036: 'const void *' : unknown size
Status: RESOLVED FIXED
Alias: None
Product: piglit
Classification: Unclassified
Component: tests (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Windows (All)
: medium blocker
Assignee: Eric Anholt
QA Contact: Eric Anholt
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2013-10-04 21:00 UTC by Vinson Lee
Modified: 2013-10-04 23:21 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Vinson Lee 2013-10-04 21:00:37 UTC
piglit: 52e999498eab372517eea41c04c048fc8382a581 (master)

overrun.c
tests\spec\arb_get_program_binary\overrun.c(64) : error C2036: 'const void *' : unknown size
tests\spec\arb_get_program_binary\overrun.c(65) : error C2036: 'const void *' : unknown size
tests\spec\arb_get_program_binary\overrun.c(129) : warning C4127: conditional expression is constant
tests\spec\arb_get_program_binary\overrun.c(130) : warning C4127: conditional expression is constant
tests\spec\arb_get_program_binary\overrun.c(131) : warning C4127: conditional expression is constant
tests\spec\arb_get_program_binary\overrun.c(132) : warning C4127: conditional expression is constant
tests\spec\arb_get_program_binary\overrun.c(133) : warning C4127: conditional expression is constant


commit a8b48101ba02a8e953422363291a7fd4a019310e
Author: Ian Romanick <ian.d.romanick@intel.com>
Date:   Tue Dec 4 15:03:05 2012 -0800

    arb_get_program_binary: Verify glGet* doesn't over-run the buffer for binary format queries
    
    This test works with both GL_PROGRAM_BINARY_FORMATS (from
    ARB_get_program_binary) and GL_SHADER_BINARY_FORMATS (from
    ARB_ES2_compatibility).  Mesa fails GL_SHADER_BINARY_FORMATS because it
    generates an error (!) for the queries.  Fix the error causes it to
    over-run the buffer.  I suspect the over-run will happen in an ES2 with
    Mesa as-is.
    
    v2: Use less terse function and parameter names.  Avoid the use of
    rand().  Both suggested by Paul.  Also move the empty piglit_display
    function to the end of the file.  This matches changes in the piglit
    test convention that were adopted after this test was initially written.
    
    Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
    Reviewed-by: Paul Berry <stereotype441@gmail.com>
Comment 1 Vinson Lee 2013-10-04 23:21:33 UTC
commit e1972d421eac89a31c9aca989e69355fb5833614
Author: Vinson Lee <vlee@freedesktop.org>
Date:   Fri Oct 4 16:12:52 2013 -0700

    arb_get_program_binary: Cast away void pointers.
    
    This patch fixes the MSVC build.
    
    arb_get_program_binary\overrun.c(64) : error C2036: 'const void *' : unknown size
    arb_get_program_binary\overrun.c(65) : error C2036: 'const void *' : unknown size
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70152
    Signed-off-by: Vinson Lee <vlee@freedesktop.org>


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.