Bug 6916 - xserver/xorg/configure.ac only works on Linux
Summary: xserver/xorg/configure.ac only works on Linux
Alias: None
Product: xorg
Classification: Unclassified
Component: Build/Modular (show other bugs)
Version: git
Hardware: x86 (IA32) OpenBSD
: high normal
Assignee: Xorg Project Team
QA Contact:
Keywords: patch
Depends on:
Blocks: 5041
  Show dependency treegraph
Reported: 2006-05-14 20:37 UTC by Matthieu Herrb
Modified: 2006-05-15 10:54 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

proposed patch (1.18 KB, patch)
2006-05-15 01:20 UTC, Matthieu Herrb
no flags Details | Splinter Review

Description Matthieu Herrb 2006-05-14 20:37:49 UTC
running configure in xserver/xorg on OpenBSD (and other non-Linux OS probably
too) now fail with:

configure: error: conditional "LNXACPI" was never defined.
Usually this means the macro was only invoked conditionally.
*** Error code 1

I'm not sure what the correct fix is, but the use of
AM_CONDITIONAL(LNXACPI,true) inside shell's 'if' conditionnals  in configure.ac
look like an abuse to me. There ought to be better ways to handle this.
Comment 1 Matthieu Herrb 2006-05-14 20:40:48 UTC
Mark as a blocker for 7.1 as the same code is present in the 1.1 branch.
Comment 2 Matthieu Herrb 2006-05-15 01:20:18 UTC
Created attachment 5629 [details] [review]
proposed patch
Comment 3 Daniel Stone 2006-05-15 02:11:56 UTC
that's fine, please apply
Comment 4 Matthieu Herrb 2006-05-15 02:24:46 UTC
Commited to head. I let ajax commit it to  the 1.1 branch before closing this.
Comment 5 Michel Dänzer 2006-05-15 16:41:39 UTC
Thanks for fixing this Matthieu, I admit to still being a relative autotools
newbie. Maybe you can also take care of re-enabling APM and ACPI support for the
BSDs? :)
Comment 6 Adam Jackson 2006-05-16 03:54:12 UTC
applied to 1.1 branch, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.