Bug 69125 - document <syslog>, <pidfile> and <allow_anonymous> for dbus-daemon(1)
Summary: document <syslog>, <pidfile> and <allow_anonymous> for dbus-daemon(1)
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.5
Hardware: Other All
: medium normal
Assignee: Havoc Pennington
QA Contact:
URL:
Whiteboard: review?
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-09-09 02:03 UTC by Chengwei Yang
Modified: 2013-11-01 12:54 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:


Attachments
[PATCH] Update configurable elements for dbus-daemon manual (1.23 KB, patch)
2013-09-09 02:25 UTC, Chengwei Yang
Details | Splinter Review
[PATCH v2] Update configurable elements for dbus-daemon manual (1.83 KB, patch)
2013-09-10 05:57 UTC, Chengwei Yang
Details | Splinter Review
[PATCH v3] Update configurable elements for dbus-daemon manual (1.80 KB, patch)
2013-09-13 12:40 UTC, Chengwei Yang
Details | Splinter Review

Description Chengwei Yang 2013-09-09 02:03:28 UTC
So far, there are three config elements undocumented in dbus-daemon(1), they're <syslog>, <pidfile>, <allow_anonymous>.

However, I'm on the way to trying remove <allow_anonymous>, it's somehow duplicated with ANONYMOUS auth mechanism and confusing.
Comment 1 Chengwei Yang 2013-09-09 02:25:34 UTC
Created attachment 85474 [details] [review]
[PATCH] Update configurable elements for dbus-daemon manual
Comment 2 Chengwei Yang 2013-09-09 02:26:40 UTC
(In reply to comment #0)
> So far, there are three config elements undocumented in dbus-daemon(1),
> they're <syslog>, <pidfile>, <allow_anonymous>.
> 
> However, I'm on the way to trying remove <allow_anonymous>, it's somehow
> duplicated with ANONYMOUS auth mechanism and confusing.

I'm on the way to try to remove <allow_anonymous/>, see http://lists.freedesktop.org/archives/dbus/2013-September/015788.html
Comment 3 Simon McVittie 2013-09-09 11:08:03 UTC
Comment on attachment 85474 [details] [review]
[PATCH] Update configurable elements for dbus-daemon manual

Review of attachment 85474 [details] [review]:
-----------------------------------------------------------------

OK
Comment 4 Simon McVittie 2013-09-09 11:09:13 UTC
(In reply to comment #2)
> I'm on the way to try to remove <allow_anonymous/>

As I mentioned on the mailing list, I don't want to merge anything that makes a previously-secure configuration insecure.
Comment 5 Chengwei Yang 2013-09-09 12:27:58 UTC
(In reply to comment #4)
> (In reply to comment #2)
> > I'm on the way to try to remove <allow_anonymous/>
> 
> As I mentioned on the mailing list, I don't want to merge anything that
> makes a previously-secure configuration insecure.

OK, I'm not insist to remove <allow_anonymous/> considering to it was already used years in fact, though should not be widely used.

I found the document patch hasn't been pushed to fd.o, so I'll upload a V2 which document <allow_anonymous/> too.
Comment 6 Chengwei Yang 2013-09-10 05:57:23 UTC
Created attachment 85530 [details] [review]
[PATCH v2] Update configurable elements for dbus-daemon manual
Comment 7 Simon McVittie 2013-09-13 12:02:08 UTC
Comment on attachment 85530 [details] [review]
[PATCH v2] Update configurable elements for dbus-daemon manual

Review of attachment 85530 [details] [review]:
-----------------------------------------------------------------

The markup in this file is pretty crazy, but it seems fine to stay consistent with what's there now.

::: doc/dbus-daemon.1.xml.in
@@ +331,5 @@
> +
> +
> +</itemizedlist>
> +
> +<para>If present, the bus daemon will write its pid to the specified file.</para>

... to the specified file. The --nopidfile command-line option takes precedence over this setting.

@@ +345,5 @@
> +auth mechanism, then the anonymous connection will be authorized.
> +Otherwise, disconnect. So if anonymous connection is wanted, both
> +ANONYMOUS auth mechanism and this option must be enabled. Looking for
> +information about enabling ANONYMOUS auth mechanism, see
> +<emphasis remap='I'>&lt;auth&gt;</emphasis> below.</para>

Perhaps this?

If present, connections that authenticated using the
ANONYMOUS mechanism will be authorized to connect.
This option has no practical effect unless the
ANONYMOUS mechanism has also been enabled
using the <emphasis remap='I'>&lt;auth&gt;</emphasis>
element, described below.
Comment 8 Chengwei Yang 2013-09-13 12:40:03 UTC
Created attachment 85765 [details] [review]
[PATCH v3] Update configurable elements for dbus-daemon manual
Comment 9 Simon McVittie 2013-11-01 12:54:32 UTC
Fixed in git for 1.7.8


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.