Bug 68601 - fails to build with a modern GNU linker
Summary: fails to build with a modern GNU linker
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: GLib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-08-27 11:23 UTC by Simon McVittie
Modified: 2013-10-21 11:23 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:


Attachments
tests: fix under-linking (564 bytes, patch)
2013-08-27 11:23 UTC, Simon McVittie
Details | Splinter Review
Avoid underlinking internal library libdbus-gtool.la (1.23 KB, patch)
2013-08-27 12:18 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2013-08-27 11:23:48 UTC
Created attachment 84697 [details] [review]
tests: fix under-linking

---

The test for errors uses dbus_set_error() so it should link -ldbus-1.
Comment 1 Simon McVittie 2013-08-27 12:18:16 UTC
Created attachment 84703 [details] [review]
Avoid underlinking internal library libdbus-gtool.la

Anything that links libdbus-gtool needs to pull in GLib/GObject,
and the order matters (things that libdbus-gtool depends on must
appear after libdbus-gtool itself). libtool understands this, but
only if you tell it the full dependencies.

This broke compilation of test-dbus-glib.exe when cross-compiling
for 32-bit Windows with mingw-w64 (GNU tuple: i686-w64-mingw32).

The linking order used here for dependencies is "lowest in the stack
first", as recommended by the GStreamer documentation.

---

Vaguely related to the above.
Comment 2 Simon McVittie 2013-10-21 11:23:23 UTC
No review, but nobody has actually said "no" either, in nearly 2 months; so I've just pushed this. Please revert it if you object.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.