Bug 6802 - prints agp info even on PCI cards
Summary: prints agp info even on PCI cards
Alias: None
Product: xorg
Classification: Unclassified
Component: Driver/Radeon (show other bugs)
Version: git
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: Xorg Project Team
QA Contact:
Keywords: patch
Depends on:
Reported: 2006-05-01 20:01 UTC by Jani Monoses
Modified: 2006-06-15 04:11 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Description Jani Monoses 2006-05-01 20:01:03 UTC
There are some unused and uninitialized vars and associated trace messages which
can confuse as they appear in the log regardless of the card type.
This is against ati_1.0 CVS

=== modified file 'a/src/radeon_driver.c'
--- a/src/radeon_driver.c
+++ b/src/radeon_driver.c
@@ -2295,7 +2295,7 @@
     RADEONInfoPtr  info   = RADEONPTR(pScrn);
     unsigned char *RADEONMMIO = info->MMIO;
-    unsigned long agp_size, agp_base, mem_size;
+    unsigned long mem_size;

     /* Default to existing values */
     info->mc_fb_location = INREG(RADEON_MC_FB_LOCATION);
@@ -2360,8 +2360,6 @@

     RADEONTRACE(("RADEONInitMemoryMap() : \n"));
     RADEONTRACE(("  mem_size         : 0x%08lx\n", mem_size));
-    RADEONTRACE(("  agp_size         : 0x%08lx\n", agp_size));
-    RADEONTRACE(("  agp_base         : 0x%08lx\n", agp_base));
     RADEONTRACE(("  MC_FB_LOCATION   : 0x%08lx\n", info->mc_fb_location));
     RADEONTRACE(("  MC_AGP_LOCATION  : 0x%08lx\n", info->mc_agp_location));
Comment 1 Michel Dänzer 2006-06-15 04:11:45 UTC
Fixed by Dave Airlie in git.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.