Bug 67828 - roster/groups.py test fails with modern telepathy-glib
Summary: roster/groups.py test fails with modern telepathy-glib
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: git master
Hardware: Other All
: high major
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-08-06 14:21 UTC by Simon McVittie
Modified: 2013-08-06 14:43 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
roster/groups: don't rely on an implementation detail (4.87 KB, patch)
2013-08-06 14:21 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2013-08-06 14:21:31 UTC
Created attachment 83723 [details] [review]
roster/groups: don't rely on an implementation detail

Before telepathy-glib 0.20.3 and 0.21.1, we had this incorrect sequence
(pseudocode) for each group:

* NewChannels(the group)
* GroupsChanged([the group], added: [...], removed: [])
* NewChannels(the group)

In 0.20.3 and 0.20.1, we removed the second emission of NewChannels
(Bug #52011). Unfortunately, that broke this test, which was specifically
expecting GroupsChanged followed by NewChannels.

Rather than reversing the assumption, I'm doing it properly, by
expecting the events in no particular order.
Comment 1 Simon McVittie 2013-08-06 14:22:31 UTC
This is for 0.16 and 0.17. We should do a 0.18 new-stable branch soon.
Comment 2 Guillaume Desmottes 2013-08-06 14:25:52 UTC
Comment on attachment 83723 [details] [review]
roster/groups: don't rely on an implementation detail

Review of attachment 83723 [details] [review]:
-----------------------------------------------------------------

++
Comment 3 Simon McVittie 2013-08-06 14:43:32 UTC
Fixed in git for 0.16.7 and 0.17.6 (or possibly 0.18.0)


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.