Bug 66481 - [PATCH] DBus Spec: fix sample service file
Summary: [PATCH] DBus Spec: fix sample service file
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.5
Hardware: Other All
: medium normal
Assignee: Havoc Pennington
QA Contact:
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-07-02 05:34 UTC by Chengwei Yang
Modified: 2013-08-23 10:47 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
[PATCH] DBus Spec: Fix sample service file (merged) (1.02 KB, patch)
2013-07-02 05:35 UTC, Chengwei Yang 		Details | Splinter Review
[PATCH] DBus Spec: fix examples namespace to com.example (4.00 KB, patch)
2013-08-23 07:56 UTC, Chengwei Yang 		Details | Splinter Review
Show Obsolete (1) View All

Description Chengwei Yang 2013-07-02 05:34:16 UTC 
Figure 9. Example service description file

            # Sample service description file
            [D-BUS Service]
            Names=org.freedesktop.ConfigurationDatabase;org.gnome.GConf;
            Exec=/usr/libexec/gconfd-2
          
There are two errors in the above sample service file.
First, a typo, Names should be Name.
Second, can not specify multiple names.
Comment 1 Chengwei Yang 2013-07-02 05:35:45 UTC 
Created attachment 81842 [details] [review]
[PATCH] DBus Spec: Fix sample service file (merged)
Comment 2 Simon McVittie 2013-08-22 18:13:28 UTC 
Comment on attachment 81842 [details] [review]
[PATCH] DBus Spec: Fix sample service file (merged)

Review of attachment 81842 [details] [review]:
-----------------------------------------------------------------

Yes.

We ought to change this to be in example.com's namespace too, really - too many people use names in freedesktop.org that they don't actually control, because they've cargo-culted "D-Bus names start with org.freedesktop".
Comment 3 Chengwei Yang 2013-08-23 07:42:20 UTC 
Yeah, someone did confused. http://lists.freedesktop.org/archives/dbus/2008-January/009113.html

I'll upload a new patch to fix samples to com.example or /com/example from org.freedesktop or /org/freedesktop.
Comment 4 Chengwei Yang 2013-08-23 07:56:01 UTC 
Created attachment 84501 [details] [review]
[PATCH] DBus Spec: fix examples namespace to com.example
Comment 5 Simon McVittie 2013-08-23 09:04:50 UTC 
Comment on attachment 84501 [details] [review]
[PATCH] DBus Spec: fix examples namespace to com.example

Review of attachment 84501 [details] [review]:
-----------------------------------------------------------------

Ideal.
Comment 6 Simon McVittie 2013-08-23 10:47:54 UTC 
Fixed in git for 1.7.6, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.