Bug 65916 - arb_texture_cube_map_array-sampler-cube-array-shadow regression
Summary: arb_texture_cube_map_array-sampler-cube-array-shadow regression
Alias: None
Product: piglit
Classification: Unclassified
Component: tests (show other bugs)
Version: unspecified
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Eric Anholt
QA Contact: Eric Anholt
Keywords: regression
Depends on:
Reported: 2013-06-18 23:42 UTC by Vinson Lee
Modified: 2013-06-24 22:21 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

arb_texture_cube_map_array: sample-cube-map-array-shadow don't mix piglit_draw_rect and custom attribute arrays (6.03 KB, patch)
2013-06-19 12:44 UTC, Fabian Bieler
Details | Splinter Review

Description Vinson Lee 2013-06-18 23:42:12 UTC
piglit: 1ae53f59681a0aa099234f78038b6b75468f0b3e (master)

Run arb_texture_cube_map_array-sampler-cube-array-shadow on Mesa softpipe.

$ ./bin/arb_texture_cube_map_array-sampler-cube-array-shadow -auto
Probe color at (101,170)
  Expected: 1.000000 1.000000 1.000000
  Observed: 0.000000 0.000000 0.000000
PIGLIT: {'result': 'fail' }

33434954cd9d4c8137ca53f03e11f32ff17ecc34 is the first bad commit
commit 33434954cd9d4c8137ca53f03e11f32ff17ecc34
Author: Fabian Bieler <fabianbieler@fastmail.fm>
Date:   Mon Jun 3 14:39:01 2013 +0200

    util: Draw rectangles using triangle strips instead of quads.
    This is useful for core profile OpenGL contexts and geometry shaders.
    Signed-off-by: Fabian Bieler <fabianbieler@fastmail.fm>
    Reviewed-by: Brian Paul <brianp@vmware.com>
    Reviewed-by: Paul Berry <stereotype441@gmail.com>

:040000 040000 373a1237f2b45d341b3e205f7afcd6b622e6394c 7f57fee724163be511ea63b6fde766b4b7275962 M	tests
bisect run success
Comment 1 Fabian Bieler 2013-06-19 12:44:08 UTC
Created attachment 81068 [details] [review]
arb_texture_cube_map_array: sample-cube-map-array-shadow don't mix piglit_draw_rect and custom attribute arrays

The problem is that my patch swapped the drawing order of the vertices which causes problems for tests that use piglit_draw_rect* with additional attribute arrays.
I'll also post this patch along with similar ones for glsl-max-varyings, copyteximage and sampler-cube-shadow to the list.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.