Bug 65517 - Automake 1.13 compatibility, and other trivia
Summary: Automake 1.13 compatibility, and other trivia
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2013-06-07 17:26 UTC by Simon McVittie
Modified: 2013-06-11 15:18 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Use AC_PROG_MKDIR_P instead of deprecated AM_PROG_MKDIR_P (8.12 KB, patch)
2013-06-07 17:27 UTC, Simon McVittie
Details | Splinter Review
util-cxx: include config.h (681 bytes, patch)
2013-06-07 17:27 UTC, Simon McVittie
Details | Splinter Review
Make tool tests executable rather than putting sh in TESTS_ENVIRONMENT (1.16 KB, patch)
2013-06-07 17:27 UTC, Simon McVittie
Details | Splinter Review
.gitignore: Automake 1.13 installs /test-driver (629 bytes, patch)
2013-06-07 17:27 UTC, Simon McVittie
Details | Splinter Review
tp_call_stream_endpoint_get_state: return a TpStreamEndpointState on error (1.05 KB, patch)
2013-06-07 17:28 UTC, Simon McVittie
Details | Splinter Review

Description Simon McVittie 2013-06-07 17:26:41 UTC
The telepathy-glib tests fail under Automake 1.13.
Comment 1 Simon McVittie 2013-06-07 17:27:12 UTC
Created attachment 80484 [details] [review]
Use AC_PROG_MKDIR_P instead of deprecated  AM_PROG_MKDIR_P

This means we define MKDIR_P instead of mkdir_p - adjust.
Strictly speaking this requires Autoconf 2.59d, but 2.60 is hardly a
new innovation (it was released in 2006).
Comment 2 Simon McVittie 2013-06-07 17:27:25 UTC
Created attachment 80485 [details] [review]
util-cxx: include config.h

This avoids a deprecation warning for g_type_init().
Comment 3 Simon McVittie 2013-06-07 17:27:44 UTC
Created attachment 80486 [details] [review]
Make tool tests executable rather than putting sh in  TESTS_ENVIRONMENT

This makes it possible to run the tool tests under the Automake 1.12+
parallel test harness, which is the default from 1.13 onwards.
Comment 4 Simon McVittie 2013-06-07 17:27:57 UTC
Created attachment 80487 [details] [review]
.gitignore: Automake 1.13 installs /test-driver
Comment 5 Simon McVittie 2013-06-07 17:28:33 UTC
Created attachment 80488 [details] [review]
tp_call_stream_endpoint_get_state: return a  TpStreamEndpointState on error

TP_MEDIA_STREAM_STATE_DISCONNECTED is from another enum entirely,
and will no longer exist in Telepathy 1.0.

---

Not really related to anything at all, but it's been gathering dust on a branch for more than a year.
Comment 6 Xavier Claessens 2013-06-11 10:11:23 UTC
Comment on attachment 80484 [details] [review]
Use AC_PROG_MKDIR_P instead of deprecated  AM_PROG_MKDIR_P

Review of attachment 80484 [details] [review]:
-----------------------------------------------------------------

ok
Comment 7 Xavier Claessens 2013-06-11 10:11:46 UTC
Comment on attachment 80485 [details] [review]
util-cxx: include config.h

Review of attachment 80485 [details] [review]:
-----------------------------------------------------------------

ok
Comment 8 Xavier Claessens 2013-06-11 10:13:01 UTC
Comment on attachment 80486 [details] [review]
Make tool tests executable rather than putting sh in  TESTS_ENVIRONMENT

Review of attachment 80486 [details] [review]:
-----------------------------------------------------------------

Assuming you don't forget +x in git, +1
Comment 9 Xavier Claessens 2013-06-11 10:13:16 UTC
Comment on attachment 80487 [details] [review]
.gitignore: Automake 1.13 installs /test-driver

Review of attachment 80487 [details] [review]:
-----------------------------------------------------------------

ok
Comment 10 Xavier Claessens 2013-06-11 10:14:16 UTC
Comment on attachment 80488 [details] [review]
tp_call_stream_endpoint_get_state: return a  TpStreamEndpointState on error

Review of attachment 80488 [details] [review]:
-----------------------------------------------------------------

ok
Comment 11 Simon McVittie 2013-06-11 15:18:32 UTC
Thanks, fixed in git for 0.20.3 (the one that actually prevents distcheck in Automake 1.13) and 0.21.1.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.