Created attachment 80366 [details] [review] Remove support for platforms with no 64-bit integer type This has been a soft requirement since 1.5.0; anyone on such platforms would have had to configure --without-64-bit, provoking a warning that instructed them to report a D-Bus bug with details of their platform. Nobody has done so, so if anyone still lacks a 64-bit integer type, they're on their own. (Also, I tried the build with --without-64-bit and it's full of fatal compiler warnings, so it's not clear that we're actually losing anything by removing this "feature".)
Comment on attachment 80366 [details] [review] Remove support for platforms with no 64-bit integer type Review of attachment 80366 [details] [review]: ----------------------------------------------------------------- ::: configure.ac @@ +385,5 @@ > AC_MSG_ERROR([Could not find a 64-bit integer type. > > Please report a bug here with details of your platform and compiler: > > + http://bugs.freedesktop.org/enter_bug.cgi?product=DBus&component=core]) Should this be removed? Since these platform will not be supported. ::: dbus/dbus-arch-deps.h.in @@ +35,1 @@ > #define DBUS_HAVE_INT64 1 I'm thinking if we can remove this definition? Also from the API document, it will not be used anymore. ::: dbus/dbus-types.h @@ +89,4 @@ > */ > > /** > * @def DBUS_HAVE_INT64 I'm thinking if we can remove this definition? It will not be used from now on.
(In reply to comment #1) > ::: configure.ac > @@ +385,5 @@ > > AC_MSG_ERROR([Could not find a 64-bit integer type. > > > > Please report a bug here with details of your platform and compiler: > > > > + http://bugs.freedesktop.org/enter_bug.cgi?product=DBus&component=core]) > > Should this be removed? Since these platform will not be supported. I'd rather hear about them (if they even exist) before we WONTFIX it. > > #define DBUS_HAVE_INT64 1 > > I'm thinking if we can remove this definition? Also from the API document, > it will not be used anymore. No, it's public API and existing correct code relies on it. "Don't break existing correct code" is one of the rules of maintaining a library.
(In reply to comment #2) > (In reply to comment #1) > > ::: configure.ac > > @@ +385,5 @@ > > > AC_MSG_ERROR([Could not find a 64-bit integer type. > > > > > > Please report a bug here with details of your platform and compiler: > > > > > > + http://bugs.freedesktop.org/enter_bug.cgi?product=DBus&component=core]) > > > > Should this be removed? Since these platform will not be supported. > > I'd rather hear about them (if they even exist) before we WONTFIX it. > > > > #define DBUS_HAVE_INT64 1 > > > > I'm thinking if we can remove this definition? Also from the API document, > > it will not be used anymore. > > No, it's public API and existing correct code relies on it. "Don't break > existing correct code" is one of the rules of maintaining a library. OK, fare enough, so r+ from me.
None of the maintainers vetoed this so I'm going to merge it.
Fixed in git for 1.7.6
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.