The X-TELEPATHY-PASSWORD pseudo mechanism needs the username, so if it is not known, don't pretend we support it. When creating a gtalk account in GOA/UOA the account parameter is set to "google.com", without the username part. In that case gabble should not claim that X-TELEPATHY-PASSWORD is supported. SASL channel handler must use google's oauth mech or even PLAIN if it can provide the username/password.
Should we also change telepathy-spec? At the moment it says > To make it possible to implement a very simple > password-querying user interface without knowledge of any > particular SASL mechanism, implementations of this interface > MUST implement the pseudo-mechanism X-TELEPATHY-PASSWORD, > unless none of the available mechanisms use a password at all. This should probably be "... unless each of the available mechanisms either requires additional information beyond the password (such as a username), or does not use a password".
Patch looks good, though.
Patch merged. Reassigning the bug to spec if someone cares :)
Created attachment 91602 [details] [review] X-TELEPATHY-PASSWORD is not mandatory if unimplementable Gabble (correctly) doesn't implement it if you use { "account": "gmail.com" }, which is not enough for X-TELEPATHY-PASSWORD: a mechanism that provides a username, such as PLAIN or Google's OAuth dialect, must be used here. --- I suggested spec text > 6 months ago. Here it is as a patch.
Comment on attachment 91602 [details] [review] X-TELEPATHY-PASSWORD is not mandatory if unimplementable Review of attachment 91602 [details] [review]: ----------------------------------------------------------------- ++
Fixed in git for 0.27.4 and 0.99.12, thanks
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.