Bug 6424 - fails to build against stable cairo 1.0.4
Summary: fails to build against stable cairo 1.0.4
Alias: None
Product: cairomm
Classification: Unclassified
Component: Build (show other bugs)
Version: CVS HEAD
Hardware: x86 (IA32) Linux (All)
: high major
Assignee: Murray Cumming
QA Contact:
Keywords: janitor, patch
Depends on:
Reported: 2006-03-29 08:03 UTC by Danilo Piazzalunga
Modified: 2006-03-29 17:30 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

stop using CAIRO_EXTEND_PAD in enums.h (1.00 KB, patch)
2006-03-29 08:07 UTC, Danilo Piazzalunga
Details | Splinter Review

Description Danilo Piazzalunga 2006-03-29 08:03:33 UTC
The cairo_extend_t enum does not include a CAIRO_EXTEND_PAD value in cairo
versions from 1.0 branch, it was added only in the 1.1 development branch.

Trying to use CAIRO_EXTEND_PAD in cairomm/enums.h causes a build failure when
building against a released cairo.
Comment 1 Danilo Piazzalunga 2006-03-29 08:07:05 UTC
Created attachment 5112 [details] [review]
stop using CAIRO_EXTEND_PAD in enums.h

Fixes the problem when building against cairo 1.0.4.

Admittedly, this looks quite ugly, but it should do the right thing and enable
EXTEND_PAD when building against cairo >= 1.1.1.
Comment 2 Murray Cumming 2006-03-29 08:12:31 UTC
It's not problem if a non-released cairomm needs a non-released cairo. Is this a
problem with any cairomm tarball release?
Comment 3 Jonathon Jongsma 2006-03-29 08:23:28 UTC
That must have slipped in when I wrapped the enums in the Cairo namespace. 
There's no tarball affected right now, but I sent out a mail on the mailing list
about making another tarball release (to benefit people trying to get this into
Fedora), so this enum should really be backed out before that happens.
Comment 4 Jonathon Jongsma 2006-03-30 11:30:59 UTC
I've committed this.  I'm not a huge fan of the conditional #if statements, but
I left them in anyway.  

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.