Bug 6096 - patch: simplify drivers src/Makefile.am (here: ATI driver)
Summary: patch: simplify drivers src/Makefile.am (here: ATI driver)
Alias: None
Product: xorg
Classification: Unclassified
Component: Build/Modular (show other bugs)
Version: git
Hardware: All All
: lowest enhancement
Assignee: Xorg Project Team
QA Contact: Xorg Project Team
Keywords: patch
Depends on:
Reported: 2006-03-02 20:34 UTC by Ralf Wildenhues
Modified: 2009-09-30 14:05 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

patch to simplify driver Makefile.am (3.46 KB, patch)
2006-03-02 20:35 UTC, Ralf Wildenhues
no flags Details | Splinter Review

Description Ralf Wildenhues 2006-03-02 20:34:26 UTC
This patch simplifies driver/xf86-video-ati/src/Makefile.am somewhat.

If you think this is desirable to have, I can probably produce similar changes
for the rest of the tree.  Note that this change causes a considerable reduction
in Makefile.in size and complexity.

Please note that
var =
var += foo
var += bar

is equivalent to
var = foo bar

and as such just a matter of taste, which one should be used,
except that, when combined with Automake conditionals, order may not be
stable in the output; this is fixed in Automake 1.9.6.  This fact has no
bearing to this patch, but may have impact to further similar changes if

Comment 1 Ralf Wildenhues 2006-03-02 20:35:11 UTC
Created attachment 4795 [details] [review]
patch to simplify driver Makefile.am
Comment 2 Erik Andren 2006-04-18 05:13:01 UTC
Added patch keyword
Comment 3 Daniel Stone 2007-02-27 01:30:42 UTC
Sorry about the phenomenal bug spam, guys.  Adding xorg-team@ to the QA contact so bugs don't get lost in future.
Comment 4 Corbin Simpson 2009-09-30 14:05:03 UTC
Closing as INVALID due to patch no longer applying.

For the record, this might have been a bit useful way back when, but the splitting-out of mach64 and r128 makes it a bit useless. If you want to refactor and resubmit this patch, feel free to do so, but I'd recommend using the mailing list for something this trivial.

~ C.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.